From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] fs: Move mark_inode_dirty out of __generic_write_end
Date: Tue, 25 Jun 2019 11:57:07 +0200 [thread overview]
Message-ID: <20190625095707.GA1462@lst.de> (raw)
In-Reply-To: <20190624182243.22447-1-agruenba@redhat.com>
On Mon, Jun 24, 2019 at 08:22:43PM +0200, Andreas Gruenbacher wrote:
> That would work, but I don't like how this leaves us with a vfs function
> that updates i_size without bothering to dirty the inode very much.
This isn't a VFS function, it is a helper library.
>
> How about if we move the __generic_write_end call into the page_done
> callback and leave special handling to the filesystem code if needed
> instead? The below patch seems to work for gfs2.
That seems way more complicated. I'd much rather go with something
like may patch plus maybe a big fat comment explaining that persisting
the size update is the file systems job. Note that a lot of the modern
file systems don't use the VFS inode tracking for that, besides XFS
that includes at least btrfs and ocfs2 as well.
next prev parent reply other threads:[~2019-06-25 9:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 14:47 [PATCH] fs: Move mark_inode_dirty out of __generic_write_end Andreas Gruenbacher
2019-06-19 16:01 ` Jan Kara
2019-06-20 4:47 ` Dave Chinner
2019-06-24 6:54 ` Christoph Hellwig
2019-06-24 18:22 ` Andreas Gruenbacher
2019-06-25 9:57 ` Christoph Hellwig [this message]
2019-06-25 10:50 ` Christoph Hellwig
2019-06-25 18:13 ` Andreas Gruenbacher
2019-06-26 6:03 ` Christoph Hellwig
2019-06-26 12:07 ` Andreas Gruenbacher
2019-06-25 15:00 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625095707.GA1462@lst.de \
--to=hch@lst.de \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).