From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15866C48BD5 for ; Tue, 25 Jun 2019 09:57:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E906D215EA for ; Tue, 25 Jun 2019 09:57:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728137AbfFYJ5k (ORCPT ); Tue, 25 Jun 2019 05:57:40 -0400 Received: from verein.lst.de ([213.95.11.211]:33296 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726421AbfFYJ5k (ORCPT ); Tue, 25 Jun 2019 05:57:40 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id F14BB68B02; Tue, 25 Jun 2019 11:57:07 +0200 (CEST) Date: Tue, 25 Jun 2019 11:57:07 +0200 From: Christoph Hellwig To: Andreas Gruenbacher Cc: Christoph Hellwig , cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org, Jan Kara Subject: Re: [PATCH] fs: Move mark_inode_dirty out of __generic_write_end Message-ID: <20190625095707.GA1462@lst.de> References: <20190618144716.8133-1-agruenba@redhat.com> <20190624065408.GA3565@lst.de> <20190624182243.22447-1-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190624182243.22447-1-agruenba@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jun 24, 2019 at 08:22:43PM +0200, Andreas Gruenbacher wrote: > That would work, but I don't like how this leaves us with a vfs function > that updates i_size without bothering to dirty the inode very much. This isn't a VFS function, it is a helper library. > > How about if we move the __generic_write_end call into the page_done > callback and leave special handling to the filesystem code if needed > instead? The below patch seems to work for gfs2. That seems way more complicated. I'd much rather go with something like may patch plus maybe a big fat comment explaining that persisting the size update is the file systems job. Note that a lot of the modern file systems don't use the VFS inode tracking for that, besides XFS that includes at least btrfs and ocfs2 as well.