* Re: [PATCH] orangefs: remove redundant assignment to variable buffer_index [not found] ` <20190521150311.GL31203@kadam> @ 2019-06-25 18:55 ` Mike Marshall 2019-06-26 6:18 ` Dan Carpenter 0 siblings, 1 reply; 3+ messages in thread From: Mike Marshall @ 2019-06-25 18:55 UTC (permalink / raw) To: Dan Carpenter, Mike Marshall, linux-fsdevel Cc: Colin King, Martin Brandenburg, devel, kernel-janitors, LKML >> The only explanation I can think of is that you guys are discussing >> different code. :P My response contained several conflations :-) ... The code in file.c that Colin has flagged does indeed have buffer_index being initialized needlessly, and the assignment noted by Dan is also needless. There's even a second needless assignment done in another place in the same function. While the code around them has changed over time, these now needless manipulations of buffer_index are not new. I'll get rid of them. >> You often send these patches before they hit linux-next so I had skipped >> reviewing this one when you sent it. I know Linus is likely to refuse pull requests for stuff that has not been through linux-next, so I make sure stuff has been there at least a few days before asking for it to be pulled. "A few days" is long enough for robots to see it, perhaps not long enough for humans. I especially appreciate the human review. One of the good things about Orangefs is that it is easy to install and configure, especially for testing. Documentation/filesystems/orangefs.txt has instructions for dnf installing orangefs on Fedora, and also how to download a source tarball and install from that. -Mike On Tue, May 21, 2019 at 11:04 AM Dan Carpenter <dan.carpenter@oracle.com> wrote: > > On Thu, May 16, 2019 at 12:06:31PM -0400, Mike Marshall wrote: > > Hi Colin... > > > > Thanks for the patch. Before I initialized buffer_index, Dan Williams sent > > in a warning that a particular error path could try to use ibuffer_index > > uninitialized. I could induce the problem he described with one > > of the xfstests resulting in a crashed kernel. I will try to refactor > > the code to fix the problem some other way than initializing > > buffer_index in the declaration. > > > > The only explanation I can think of is that you guys are discussing > different code. :P > > regards, > dan carpenter > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] orangefs: remove redundant assignment to variable buffer_index 2019-06-25 18:55 ` [PATCH] orangefs: remove redundant assignment to variable buffer_index Mike Marshall @ 2019-06-26 6:18 ` Dan Carpenter 2019-06-26 14:56 ` Colin Ian King 0 siblings, 1 reply; 3+ messages in thread From: Dan Carpenter @ 2019-06-26 6:18 UTC (permalink / raw) To: Mike Marshall Cc: linux-fsdevel, Colin King, Martin Brandenburg, devel, kernel-janitors, LKML On Tue, Jun 25, 2019 at 02:55:11PM -0400, Mike Marshall wrote: > >> You often send these patches before they hit linux-next so I had skipped > >> reviewing this one when you sent it. > > I know Linus is likely to refuse pull requests for stuff that > has not been through linux-next, so I make sure stuff has been > there at least a few days before asking for it to be pulled. > "A few days" is long enough for robots to see it, perhaps not > long enough for humans. I especially appreciate the human review. One of > the good things about Orangefs is that it is easy to install and configure, > especially for testing. Documentation/filesystems/orangefs.txt has > instructions for dnf installing orangefs on Fedora, and also how to download > a source tarball and install from that. No, no, that comment was to Colin. It's good that he's sending patches for all the trees as soon as possible like the zero day bot does. But it does make it hard to review at times. regards, dan carpenter ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] orangefs: remove redundant assignment to variable buffer_index 2019-06-26 6:18 ` Dan Carpenter @ 2019-06-26 14:56 ` Colin Ian King 0 siblings, 0 replies; 3+ messages in thread From: Colin Ian King @ 2019-06-26 14:56 UTC (permalink / raw) To: Dan Carpenter, Mike Marshall Cc: linux-fsdevel, Martin Brandenburg, devel, kernel-janitors, LKML On 26/06/2019 07:18, Dan Carpenter wrote: > On Tue, Jun 25, 2019 at 02:55:11PM -0400, Mike Marshall wrote: >>>> You often send these patches before they hit linux-next so I had skipped >>>> reviewing this one when you sent it. >> >> I know Linus is likely to refuse pull requests for stuff that >> has not been through linux-next, so I make sure stuff has been >> there at least a few days before asking for it to be pulled. >> "A few days" is long enough for robots to see it, perhaps not >> long enough for humans. I especially appreciate the human review. One of >> the good things about Orangefs is that it is easy to install and configure, >> especially for testing. Documentation/filesystems/orangefs.txt has >> instructions for dnf installing orangefs on Fedora, and also how to download >> a source tarball and install from that. > > No, no, that comment was to Colin. It's good that he's sending patches > for all the trees as soon as possible like the zero day bot does. But > it does make it hard to review at times. > > regards, > dan carpenter > Indeed, I normally work against the latest code landing in linux-next, so apologies for any confusion. Anyhow, by the look of it these minor nitpicks still need addressing (really low priority), so shall I leave that with you Mike to sort out? Colin ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-26 14:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190511132700.4862-1-colin.king@canonical.com>
[not found] ` <CAOg9mSQt42NQu-3nwZOCGOPx45y7G8aaiDaVe4SwotGnD9iY1A@mail.gmail.com>
[not found] ` <20190521150311.GL31203@kadam>
2019-06-25 18:55 ` [PATCH] orangefs: remove redundant assignment to variable buffer_index Mike Marshall
2019-06-26 6:18 ` Dan Carpenter
2019-06-26 14:56 ` Colin Ian King
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).