From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01B76C48BD3 for ; Wed, 26 Jun 2019 12:55:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9C9E2168B for ; Wed, 26 Jun 2019 12:55:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727518AbfFZMze (ORCPT ); Wed, 26 Jun 2019 08:55:34 -0400 Received: from verein.lst.de ([213.95.11.211]:42926 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726948AbfFZMzd (ORCPT ); Wed, 26 Jun 2019 08:55:33 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id C479768B05; Wed, 26 Jun 2019 14:55:02 +0200 (CEST) Date: Wed, 26 Jun 2019 14:55:02 +0200 From: Christoph Hellwig To: Andreas Gruenbacher Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com, linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/2] iomap: don't mark the inode dirty in iomap_write_end Message-ID: <20190626125502.GB4744@lst.de> References: <20190626120333.13310-1-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190626120333.13310-1-agruenba@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Jun 26, 2019 at 02:03:32PM +0200, Andreas Gruenbacher wrote: > Marking the inode dirty for each page copied into the page cache can be > very inefficient for file systems that use the VFS dirty inode tracking, > and is completely pointless for those that don't use the VFS dirty inode > tracking. So instead, only set an iomap flag when changing the in-core > inode size, and open code the rest of __generic_write_end. > > Signed-off-by: Christoph Hellwig > Signed-off-by: Andreas Gruenbacher Nitpick: a patch from you should never have me as the first signoff. Just drop it, and if you feel fancy add a 'Partially based on code from Christoph Hellwig.' sentence. Not that I care much. Otherwise looks good: Reviewed-by: Christoph Hellwig Doesn't the series also need a third patch reducing the amount of mark_inode_dirty calls as per your initial proposal?