From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91E67C48BD3 for ; Wed, 26 Jun 2019 13:38:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74895204EC for ; Wed, 26 Jun 2019 13:38:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727437AbfFZNiB (ORCPT ); Wed, 26 Jun 2019 09:38:01 -0400 Received: from verein.lst.de ([213.95.11.211]:43253 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727258AbfFZNiB (ORCPT ); Wed, 26 Jun 2019 09:38:01 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 0BD7568B05; Wed, 26 Jun 2019 15:37:30 +0200 (CEST) Date: Wed, 26 Jun 2019 15:37:29 +0200 From: Christoph Hellwig To: Andreas Gruenbacher Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com, linux-xfs@vger.kernel.org Subject: Re: [PATCH v2 3/3] iomap: fix page_done callback for short writes Message-ID: <20190626133729.GA5849@lst.de> References: <20190626132335.14809-1-agruenba@redhat.com> <20190626132335.14809-3-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190626132335.14809-3-agruenba@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Jun 26, 2019 at 03:23:35PM +0200, Andreas Gruenbacher wrote: > When we truncate a short write to have it retried, pass the truncated > length to the page_done callback instead of the full length. > > Signed-off-by: Andreas Gruenbacher Looks good: Reviewed-by: Christoph Hellwig