From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D1FCC4321A for ; Fri, 28 Jun 2019 14:32:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51CA0205C9 for ; Fri, 28 Jun 2019 14:32:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="lTxr/EJA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726902AbfF1OcS (ORCPT ); Fri, 28 Jun 2019 10:32:18 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:44652 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726657AbfF1OcS (ORCPT ); Fri, 28 Jun 2019 10:32:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=z59db2q7R3Qs4jp6ksud3JOvoxe9K7xlif6grC7p/kQ=; b=lTxr/EJA0YdHAqSEH5qzLBFLP 42jOlBpT1JbuRG1wvwBpQ1qa/LBkUgDyp0fRyqB8o7sd7EqPfyrEM0WLXHygnty5VH2cmYV4+Z92O OYS5NAee8o2LgdZkFFeLtBEtyCczqi8Fj3ouPyTEnoTX2bkEL6xOByS5DFV8wulLt5WOrzz80KPoY 1Fr240ld04fT4A1O5Cn6HNomln9tUVmVtT72MgirYml/jWFeYldqHdU4lDRP08MP1MTpPnhJRZYwI 6N/HeiuZdzewgesoTQVrYFRrSG8hpRrPB0WsPnGngrIvd9FKAaAYRV8SJCfUIywKaotBoJbImlXaQ IKQmfjCwg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hgrvE-0001us-LS; Fri, 28 Jun 2019 14:32:16 +0000 Date: Fri, 28 Jun 2019 07:32:16 -0700 From: Christoph Hellwig To: OGAWA Hirofumi Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fat: Add nobarrier to workaround the strange behavior of device Message-ID: <20190628143216.GA538@infradead.org> References: <871rzdrdxw.fsf@mail.parknet.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871rzdrdxw.fsf@mail.parknet.co.jp> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Jun 28, 2019 at 11:18:19PM +0900, OGAWA Hirofumi wrote: > To workaround those devices and provide flexibility, this adds > "barrier"/"nobarrier" mount options to fat driver. We have deprecated these rather misnamed options, and now instead allow tweaking the 'cache_type' attribute on the SCSI device. That being said if the device behave this buggy you should also report it to to the usb-storage and scsi maintainers so that we can add a quirk for it.