From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Chao Yu <yuchao0@huawei.com>,
hch@infradead.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, gaoxiang25@huawei.com,
chao@kernel.org, Andreas Gruenbacher <agruenba@redhat.com>
Subject: Re: [PATCH RFC] iomap: introduce IOMAP_TAIL
Date: Sun, 30 Jun 2019 23:08:47 -0700 [thread overview]
Message-ID: <20190701060847.GA24797@infradead.org> (raw)
In-Reply-To: <20190630231932.GI1404256@magnolia>
On Sun, Jun 30, 2019 at 04:19:32PM -0700, Darrick J. Wong wrote:
> On Sat, Jun 29, 2019 at 03:30:20PM +0800, Chao Yu wrote:
> > Some filesystems like erofs/reiserfs have the ability to pack tail
> > data into metadata, however iomap framework can only support mapping
> > inline data with IOMAP_INLINE type, it restricts that:
> > - inline data should be locating at page #0.
> > - inline size should equal to .i_size
>
> Wouldn't it be easier simply to fix the meaning of IOMAP_INLINE so that
> it can be used at something other than offset 0 and length == isize?
> IOWs, make it mean "use the *inline_data pointer to read/write data
> as a direct memory access"?
Yes. I vaguely remember Andreas pointed out some issues with a
general scheme, which is why we put the limits in. If that is not just
me making things up we'll need to address them. Either way just copy
and pasting code isn't very helpful.
next prev parent reply other threads:[~2019-07-01 6:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-29 7:30 [PATCH RFC] iomap: introduce IOMAP_TAIL Chao Yu
2019-06-29 9:34 ` Gao Xiang
2019-07-01 6:40 ` Chao Yu
2019-07-01 7:03 ` Gao Xiang
2019-07-01 9:49 ` Andreas Grünbacher
2019-07-01 10:07 ` Chao Yu
2019-07-01 10:13 ` Andreas Grünbacher
2019-07-01 10:22 ` Chao Yu
2019-06-30 23:19 ` Darrick J. Wong
2019-07-01 6:08 ` Christoph Hellwig [this message]
2019-07-01 7:38 ` Chao Yu
2019-07-01 7:28 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190701060847.GA24797@infradead.org \
--to=hch@infradead.org \
--cc=agruenba@redhat.com \
--cc=chao@kernel.org \
--cc=darrick.wong@oracle.com \
--cc=gaoxiang25@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).