From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B1D1C48BDE for ; Sun, 7 Jul 2019 18:54:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35AE120684 for ; Sun, 7 Jul 2019 18:54:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727384AbfGGSyt (ORCPT ); Sun, 7 Jul 2019 14:54:49 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:47080 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727373AbfGGSyt (ORCPT ); Sun, 7 Jul 2019 14:54:49 -0400 Received: from callcc.thunk.org (75-104-86-74.mobility.exede.net [75.104.86.74] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x67IsJgr016282 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 7 Jul 2019 14:54:26 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 7EC8C42002E; Sun, 7 Jul 2019 14:54:18 -0400 (EDT) Date: Sun, 7 Jul 2019 14:54:18 -0400 From: "Theodore Ts'o" To: Eric Biggers Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-integrity@vger.kernel.org, Jaegeuk Kim , Victor Hsieh , Chandan Rajendra , Dave Chinner , Christoph Hellwig , "Darrick J . Wong" , Linus Torvalds Subject: Re: [PATCH v6 15/17] ext4: add fs-verity read support Message-ID: <20190707185418.GD19775@mit.edu> References: <20190701153237.1777-1-ebiggers@kernel.org> <20190701153237.1777-16-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190701153237.1777-16-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jul 01, 2019 at 08:32:35AM -0700, Eric Biggers wrote: > From: Eric Biggers > > Make ext4_mpage_readpages() verify data as it is read from fs-verity > files, using the helper functions from fs/verity/. > > To support both encryption and verity simultaneously, this required > refactoring the decryption workflow into a generic "post-read > processing" workflow which can do decryption, verification, or both. > > The case where the ext4 block size is not equal to the PAGE_SIZE is not > supported yet, since in that case ext4_mpage_readpages() sometimes falls > back to block_read_full_page(), which does not support fs-verity yet. > > Co-developed-by: Theodore Ts'o > Signed-off-by: Theodore Ts'o > Signed-off-by: Eric Biggers Looks good. Since there's a S-o-B, some might claim that a Reviewed-by: is not necessary, but to the extent that you modified this code as well: Reviewed-by: Theodore Ts'o - Ted