From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF1B4C48BDE for ; Sun, 7 Jul 2019 20:43:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C5D2520693 for ; Sun, 7 Jul 2019 20:43:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="VEynfwpc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727481AbfGGUnd (ORCPT ); Sun, 7 Jul 2019 16:43:33 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:59890 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727341AbfGGUnd (ORCPT ); Sun, 7 Jul 2019 16:43:33 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x67KctMx027492; Sun, 7 Jul 2019 20:43:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=6hBxH4XrKftdFNOpQ7bLkx+ErCc58NpfzAi14wvQyhY=; b=VEynfwpc7+wB4HF/DBjTgJbx/P2SauiSzAtBpAFVXI3bMoAnD/XvBp/CHOW72CUZyYMo oXnH9zM/UxK2qt5CJueeCRSl/BJ7zc6YoPv+QnNQ6rwFgeP33G5TKbjZRowpPrisw5Td 41Dwg+qPaOAJuQbo4kPKOraddp2Nkqt1XUdIZRpy/p3nvN9wrprl7OBxMbgwSwFOfDyo BkaWujbckq0pOLnzgxFjJFjpBhNJ4lc5GgvUl/e00gWX+Sm7zcGP9n+J8ss7Sg9Nnp3a r0fy0HqrzxDx0maDR8qlMi38lwX8jS+rZ9SPsc6vnERgORUgUDHJCflPVUZ+nmmeo3eU MQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2tjk2tbaax-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 07 Jul 2019 20:43:23 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x67KcK2Z145282; Sun, 7 Jul 2019 20:41:22 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2tjgrt7mh7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 07 Jul 2019 20:41:22 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x67KfLjp018277; Sun, 7 Jul 2019 20:41:21 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 07 Jul 2019 13:41:21 -0700 Date: Sun, 7 Jul 2019 13:41:17 -0700 From: "Darrick J. Wong" To: Eric Biggers Cc: Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/3] f2fs: use generic checking and prep function for FS_IOC_SETFLAGS Message-ID: <20190707204117.GI1654093@magnolia> References: <20190701202630.43776-1-ebiggers@kernel.org> <20190701202630.43776-2-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190701202630.43776-2-ebiggers@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9311 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907070289 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9311 signatures=668688 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907070289 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jul 01, 2019 at 01:26:28PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Make the f2fs implementation of FS_IOC_SETFLAGS use the new VFS helper > function vfs_ioc_setflags_prepare(). > > This is based on a patch from Darrick Wong, but reworked to apply after > commit 360985573b55 ("f2fs: separate f2fs i_flags from fs_flags and ext4 > i_flags"). > > Originally-from: Darrick J. Wong > Signed-off-by: Eric Biggers LGTM, Reviewed-by: Darrick J. Wong --D > --- > fs/f2fs/file.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index e7c368db81851f..b5b941e6448657 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -1765,7 +1765,8 @@ static int f2fs_ioc_getflags(struct file *filp, unsigned long arg) > static int f2fs_ioc_setflags(struct file *filp, unsigned long arg) > { > struct inode *inode = file_inode(filp); > - u32 fsflags; > + struct f2fs_inode_info *fi = F2FS_I(inode); > + u32 fsflags, old_fsflags; > u32 iflags; > int ret; > > @@ -1789,8 +1790,14 @@ static int f2fs_ioc_setflags(struct file *filp, unsigned long arg) > > inode_lock(inode); > > + old_fsflags = f2fs_iflags_to_fsflags(fi->i_flags); > + ret = vfs_ioc_setflags_prepare(inode, old_fsflags, fsflags); > + if (ret) > + goto out; > + > ret = f2fs_setflags_common(inode, iflags, > f2fs_fsflags_to_iflags(F2FS_SETTABLE_FS_FL)); > +out: > inode_unlock(inode); > mnt_drop_write_file(filp); > return ret; > -- > 2.22.0.410.gd8fdbe21b5-goog >