From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B28DC606BD for ; Mon, 8 Jul 2019 16:19:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F09BB20693 for ; Mon, 8 Jul 2019 16:19:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729967AbfGHQTP (ORCPT ); Mon, 8 Jul 2019 12:19:15 -0400 Received: from verein.lst.de ([213.95.11.211]:34828 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728118AbfGHQTP (ORCPT ); Mon, 8 Jul 2019 12:19:15 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id B33B3227A81; Mon, 8 Jul 2019 18:19:12 +0200 (CEST) Date: Mon, 8 Jul 2019 18:19:12 +0200 From: Christoph Hellwig To: Dave Chinner Cc: Christoph Hellwig , Andreas Gruenbacher , "Darrick J . Wong" , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com Subject: Re: RFC: use the iomap writepage path in gfs2 Message-ID: <20190708161912.GA10233@lst.de> References: <20190701215439.19162-1-hch@lst.de> <20190708000103.GH7689@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190708000103.GH7689@dread.disaster.area> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jul 08, 2019 at 10:01:03AM +1000, Dave Chinner wrote: > Ok, this doesn't look too bad from the iomap perspective, though it > does raise more questions. :) > > gfs2 now has two iopaths, right? One that uses bufferheads for > journalled data, and the other that uses iomap? That seems like it's > only a partial conversion - what needs to be done to iomap and gfs2 > to support the journalled data path so there's a single data IO > path? gfs2 always had to very different writeback I/O paths, including a copy and pasted versiom of write_cache_pages for journaled data, they just diverge a little bit more now. In the longer run I'd also like to add journaled data support to iomap for use with XFS, and then also switch gfs2 to it.