From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: hch@infradead.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH RFC 00/11] iomap: regroup code by functional area
Date: Mon, 8 Jul 2019 11:46:52 -0700 [thread overview]
Message-ID: <20190708184652.GB20670@infradead.org> (raw)
In-Reply-To: <156200051933.1790352.5147420943973755350.stgit@magnolia>
On Mon, Jul 01, 2019 at 10:01:59AM -0700, Darrick J. Wong wrote:
> Hi all,
>
> This series breaks up fs/iomap.c by grouping the functions by major
> functional area (swapfiles, fiemap, seek hole/data, directio, buffered
> writes, buffered reads, page management, and page migration) in separate
> source code files under fs/iomap/. No functional changes have been
> made.
>
> Note that this is not the final format of the patches, because I intend
> to pick a point towards the end of the merge window (after everyone
> else's merges have landed), rebase this series atop that, and push it
> back to Linus. The RFC is posted so that everyone can provide feedback
> on the grouping strategy, not line-specific code movements.
>
> This has been lightly tested with fstests. Enjoy!
> Comments and questions are, as always, welcome.
Do you have a branch somewhere for the layout?
To me it seems to be a little too fine grained and creates tons of tiny
files, which make hacking the code painful.
next prev parent reply other threads:[~2019-07-08 18:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 17:01 [PATCH RFC 00/11] iomap: regroup code by functional area Darrick J. Wong
2019-07-01 17:02 ` [PATCH 01/11] iomap: start moving code to fs/iomap/ Darrick J. Wong
2019-07-01 17:02 ` [PATCH 02/11] iomap: move the swapfile code into a separate file Darrick J. Wong
2019-07-01 17:02 ` [PATCH 03/11] iomap: move the file mapping reporting " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 04/11] iomap: move the SEEK_HOLE " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 05/11] iomap: move the direct IO " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 06/11] iomap: move the buffered write " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 07/11] iomap: move the buffered read " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 08/11] iomap: move the page management " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 09/11] iomap: move the page migration " Darrick J. Wong
2019-07-01 17:03 ` [PATCH 10/11] iomap: move the main iteration " Darrick J. Wong
2019-07-01 17:03 ` [PATCH 11/11] iomap: move internal declarations into fs/iomap/ Darrick J. Wong
2019-07-01 17:41 ` [PATCH RFC 00/11] iomap: regroup code by functional area Theodore Ts'o
2019-07-01 17:59 ` Darrick J. Wong
2019-07-08 18:46 ` Christoph Hellwig [this message]
2019-07-09 16:49 ` Darrick J. Wong
2019-07-09 18:12 ` Christoph Hellwig
2019-07-15 16:43 ` Darrick J. Wong
2019-07-15 16:50 ` Christoph Hellwig
2019-07-15 17:49 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708184652.GB20670@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).