From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 090B8C606BD for ; Mon, 8 Jul 2019 18:46:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE8DB21874 for ; Mon, 8 Jul 2019 18:46:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ggZMUBpp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388316AbfGHSqx (ORCPT ); Mon, 8 Jul 2019 14:46:53 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:52310 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728109AbfGHSqx (ORCPT ); Mon, 8 Jul 2019 14:46:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dKndpnfDRuzEXqd8NESls6FfbKscantgDxBPwqxYH2I=; b=ggZMUBppZ87RS3mus7iWCiTgQ rz2CoMNWgChuBgw9eD1CQ8+ATPL1evNAgZLZGdKBKSOxXvnQ9IBD13LuFPBw9m9SZWj7Wh6quOXce d80b/elXqmxei/DpTySs5EoIuFIo9hxKuQ2aioKn04jpLlAUGhXTnD6UxbTmzcO4GIf553j1WpckN DbABu0OmCv4ylMcruTT00rKe2R6DOfmMcBlNCl8020SAJiXw8uJkwN4hK4NsHEOpoTtdQ2zKZdLGi lxEkAurzQCYD1/Lr9R+b0ixwuomleaGbvlmBdkGWxIdfaBeEBNO+gFHVpi+acxYSwWajd+jozxTZ5 +FySg7d5w==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hkYf6-0007Wh-KL; Mon, 08 Jul 2019 18:46:52 +0000 Date: Mon, 8 Jul 2019 11:46:52 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: hch@infradead.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH RFC 00/11] iomap: regroup code by functional area Message-ID: <20190708184652.GB20670@infradead.org> References: <156200051933.1790352.5147420943973755350.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <156200051933.1790352.5147420943973755350.stgit@magnolia> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jul 01, 2019 at 10:01:59AM -0700, Darrick J. Wong wrote: > Hi all, > > This series breaks up fs/iomap.c by grouping the functions by major > functional area (swapfiles, fiemap, seek hole/data, directio, buffered > writes, buffered reads, page management, and page migration) in separate > source code files under fs/iomap/. No functional changes have been > made. > > Note that this is not the final format of the patches, because I intend > to pick a point towards the end of the merge window (after everyone > else's merges have landed), rebase this series atop that, and push it > back to Linus. The RFC is posted so that everyone can provide feedback > on the grouping strategy, not line-specific code movements. > > This has been lightly tested with fstests. Enjoy! > Comments and questions are, as always, welcome. Do you have a branch somewhere for the layout? To me it seems to be a little too fine grained and creates tons of tiny files, which make hacking the code painful.