From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH RFC 00/11] iomap: regroup code by functional area
Date: Tue, 9 Jul 2019 11:12:14 -0700 [thread overview]
Message-ID: <20190709181214.GA31130@infradead.org> (raw)
In-Reply-To: <20190709164952.GT1404256@magnolia>
I looked over it and while some of the small files seem very tiny
they are reasonably split.
What rather annoys me is the page.c/read.c/write.c split. All these
really belong mostly together, except maybe the super highlevel
write code that then either calls into the buffer_head vs iomap_page
based code. By keeping them together we can eliminate most of
iomap_internal.h and once the writeback code moves also keep
iomap_page private to that bigger read.c file.
A few other minor notes:
- I think iomap_sector() should move to linux/iomap.h as an inline
helper.
- iomap_actor_t / iomap_apply should probaby just move to linux/iomap.h
as well, which would avoid needing the awkward subdir include in
dax.c
- some of the copyrights for the small files seem totally wrong.
e.g. all the swapfile code was written by you, so it should not have
my or rh copyright notices on it
next prev parent reply other threads:[~2019-07-09 18:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 17:01 [PATCH RFC 00/11] iomap: regroup code by functional area Darrick J. Wong
2019-07-01 17:02 ` [PATCH 01/11] iomap: start moving code to fs/iomap/ Darrick J. Wong
2019-07-01 17:02 ` [PATCH 02/11] iomap: move the swapfile code into a separate file Darrick J. Wong
2019-07-01 17:02 ` [PATCH 03/11] iomap: move the file mapping reporting " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 04/11] iomap: move the SEEK_HOLE " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 05/11] iomap: move the direct IO " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 06/11] iomap: move the buffered write " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 07/11] iomap: move the buffered read " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 08/11] iomap: move the page management " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 09/11] iomap: move the page migration " Darrick J. Wong
2019-07-01 17:03 ` [PATCH 10/11] iomap: move the main iteration " Darrick J. Wong
2019-07-01 17:03 ` [PATCH 11/11] iomap: move internal declarations into fs/iomap/ Darrick J. Wong
2019-07-01 17:41 ` [PATCH RFC 00/11] iomap: regroup code by functional area Theodore Ts'o
2019-07-01 17:59 ` Darrick J. Wong
2019-07-08 18:46 ` Christoph Hellwig
2019-07-09 16:49 ` Darrick J. Wong
2019-07-09 18:12 ` Christoph Hellwig [this message]
2019-07-15 16:43 ` Darrick J. Wong
2019-07-15 16:50 ` Christoph Hellwig
2019-07-15 17:49 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709181214.GA31130@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).