From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03097C74A36 for ; Wed, 10 Jul 2019 20:15:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA8562064A for ; Wed, 10 Jul 2019 20:15:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="QqvxyQ/j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727263AbfGJUPn (ORCPT ); Wed, 10 Jul 2019 16:15:43 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:56876 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727004AbfGJUPm (ORCPT ); Wed, 10 Jul 2019 16:15:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=TneDxC5vwBl8tHPTt+hx98vFK0V+NjAtmdMURbie6aI=; b=QqvxyQ/jMxX71GYdnj31MmGR3 gIeJSHz2uz8UcrOq92xcYenNrHWfTRttrl8uNx0ZY7g8+Mi6O6xNLYFgO6U+xPGX2Z3tLw27LrBFJ T2hi2lw1l7NolR2u0V2g6AIHX0/ntXI0IzAJr+3kRrvMvE4fRFIr+k5ALWRNkPqYpQ/4QWeSrgwRs kL7nQZOfsqMlSEhJnJ9JWLQOg44dVC2RR1CyJoj8Z3FoBUdzke07RP1i9jfFZv8cby6i0dO1JHT2r lNoRSvHeaGzI1GutlMvAtMFOCgnf+e3IAwlWb1XMvGcu8E9KqyqN3MhbPqJCcrCTekvfQUy2maHjs 2LtCZGABg==; Received: from willy by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hlJ07-0006Cj-UN; Wed, 10 Jul 2019 20:15:39 +0000 Date: Wed, 10 Jul 2019 13:15:39 -0700 From: Matthew Wilcox To: Jan Kara Cc: Dan Williams , linux-fsdevel , Boaz Harrosh , stable , Robert Barror , Seema Pandit , linux-nvdimm , Linux Kernel Mailing List Subject: Re: [PATCH] dax: Fix missed PMD wakeups Message-ID: <20190710201539.GN32320@bombadil.infradead.org> References: <20190703195302.GJ1729@bombadil.infradead.org> <20190704032728.GK1729@bombadil.infradead.org> <20190704165450.GH31037@quack2.suse.cz> <20190704191407.GM1729@bombadil.infradead.org> <20190705191004.GC32320@bombadil.infradead.org> <20190710190204.GB14701@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190710190204.GB14701@quack2.suse.cz> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Jul 10, 2019 at 09:02:04PM +0200, Jan Kara wrote: > +#define DAX_ENTRY_CONFLICT dax_make_entry(pfn_to_pfn_t(1), DAX_EMPTY) I was hoping to get rid of DAX_EMPTY ... it's almost unused now. Once we switch to having a single DAX_LOCK value instead of a single bit, I think it can go away, freeing up two bits. If you really want a special DAX_ENTRY_CONFLICT, I think we can make one in the 2..4094 range. That aside, this looks pretty similar to the previous patch I sent, so if you're now happy with this, let's add #define XA_DAX_CONFLICT_ENTRY xa_mk_internal(258) to xarray.h and do it that way?