From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=3.0 tests=DATE_IN_PAST_12_24, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2534CC742AE for ; Fri, 12 Jul 2019 09:14:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 087112166E for ; Fri, 12 Jul 2019 09:14:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726664AbfGLJN5 (ORCPT ); Fri, 12 Jul 2019 05:13:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:54274 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726138AbfGLJN5 (ORCPT ); Fri, 12 Jul 2019 05:13:57 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 93769AC63; Fri, 12 Jul 2019 09:13:55 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 3D21A1E43CB; Thu, 11 Jul 2019 17:41:11 +0200 (CEST) Date: Thu, 11 Jul 2019 17:41:11 +0200 From: Jan Kara To: Matthew Wilcox Cc: Jan Kara , Dan Williams , linux-fsdevel , Boaz Harrosh , stable , Robert Barror , Seema Pandit , linux-nvdimm , Linux Kernel Mailing List Subject: Re: [PATCH] dax: Fix missed PMD wakeups Message-ID: <20190711154111.GA29284@quack2.suse.cz> References: <20190704165450.GH31037@quack2.suse.cz> <20190704191407.GM1729@bombadil.infradead.org> <20190705191004.GC32320@bombadil.infradead.org> <20190710190204.GB14701@quack2.suse.cz> <20190710201539.GN32320@bombadil.infradead.org> <20190710202647.GA7269@quack2.suse.cz> <20190711141350.GS32320@bombadil.infradead.org> <20190711152550.GT32320@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190711152550.GT32320@bombadil.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu 11-07-19 08:25:50, Matthew Wilcox wrote: > On Thu, Jul 11, 2019 at 07:13:50AM -0700, Matthew Wilcox wrote: > > However, the XA_RETRY_ENTRY might be a good choice. It doesn't normally > > appear in an XArray (it may appear if you're looking at a deleted node, > > but since we're holding the lock, we can't see deleted nodes). > ... > @@ -254,7 +267,7 @@ static void wait_entry_unlocked(struct xa_state *xas, void *entry) > static void put_unlocked_entry(struct xa_state *xas, void *entry) > { > /* If we were the only waiter woken, wake the next one */ > - if (entry) > + if (entry && dax_is_conflict(entry)) This should be !dax_is_conflict(entry)... > dax_wake_entry(xas, entry, false); > } Otherwise the patch looks good to me so feel free to add: Reviewed-by: Jan Kara once you fix this. Honza -- Jan Kara SUSE Labs, CR