From: Jan Kara <jack@suse.cz>
To: Steve Magnani <steve.magnani@digidescorp.com>
Cc: "Jan Kara" <jack@suse.cz>,
"Steven J . Magnani" <steve@digidescorp.com>,
"Pali Rohár" <pali.rohar@gmail.com>, "Jan Kara" <jack@suse.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] udf: support 2048-byte spacing of VRS descriptors on 4K media
Date: Fri, 12 Jul 2019 11:34:38 +0200 [thread overview]
Message-ID: <20190712093438.GD906@quack2.suse.cz> (raw)
In-Reply-To: <6abea3a8-53da-f7ed-33f5-a9ecfd386c56@digidescorp.com>
On Thu 11-07-19 10:56:52, Steve Magnani wrote:
> On 7/11/19 10:04 AM, Jan Kara wrote:
> > Thanks for the patches! I've added them to my tree and somewhat simplified
> > the logic since we don't really care about nsr 2 vs 3 or whether we
> > actually saw BEA or not. Everything seems to work fine for me but I'd
> > appreciate if you could doublecheck - the result is pushed out to
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git for_next
> >
> Tested-by: Steven J. Magnani <steve@digidescorp.com>
>
> The rework is more permissive than what you had suggested initially
> (conditioning acceptance of a noncompliant NSR on a preceding BEA).
> I had also tried to code the original so that a malformed 2048-byte
> interval VRS would not be accepted. But the simplifications do make
> the code easier to follow...
Yeah, it's simpler to follow and we do this check just to see whether this
may be a valid UDF media before doing more expensive probing. So I don't
think that the code being more permissive matters. Thanks for testing!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2019-07-12 9:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 13:38 [PATCH v2 1/2] udf: refactor VRS descriptor identification Steven J. Magnani
2019-07-11 13:38 ` [PATCH v2 2/2] udf: support 2048-byte spacing of VRS descriptors on 4K media Steven J. Magnani
2019-07-11 15:04 ` Jan Kara
2019-07-11 15:56 ` Steve Magnani
2019-07-12 9:34 ` Jan Kara [this message]
2019-07-11 18:15 ` [PATCH v2 1/2] udf: refactor VRS descriptor identification Pali Rohár
2019-07-12 9:35 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712093438.GD906@quack2.suse.cz \
--to=jack@suse.cz \
--cc=jack@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=steve.magnani@digidescorp.com \
--cc=steve@digidescorp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).