From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH RFC 00/11] iomap: regroup code by functional area
Date: Mon, 15 Jul 2019 10:49:44 -0700 [thread overview]
Message-ID: <20190715174944.GC6147@magnolia> (raw)
In-Reply-To: <20190715165012.GA32624@infradead.org>
On Mon, Jul 15, 2019 at 09:50:13AM -0700, Christoph Hellwig wrote:
> On Mon, Jul 15, 2019 at 09:43:07AM -0700, Darrick J. Wong wrote:
> > On Tue, Jul 09, 2019 at 11:12:14AM -0700, Christoph Hellwig wrote:
> > > I looked over it and while some of the small files seem very tiny
> > > they are reasonably split.
> > >
> > > What rather annoys me is the page.c/read.c/write.c split. All these
> > > really belong mostly together, except maybe the super highlevel
> > > write code that then either calls into the buffer_head vs iomap_page
> > > based code. By keeping them together we can eliminate most of
> > > iomap_internal.h and once the writeback code moves also keep
> > > iomap_page private to that bigger read.c file.
> >
> > <nod> I think it makes sense to combine them into a single read_write.c
> > file or something.
>
> page.c or buffered-io.c seems like sensible names to me.
buffered-io.c it is then.
> > > - some of the copyrights for the small files seem totally wrong.
> > > e.g. all the swapfile code was written by you, so it should not have
> > > my or rh copyright notices on it
> >
> > Will fix the swapfile code.
>
> Please also look over the other files, a few of them should probably
> be just me (e.g. fiemap) and some have other authors (seek is mostly
> Andreas with a few later bits from me).
<nod> I'll edit the copyrights on fiemap.c. I'm less sure about making
edits to seek.c because I don't know if Andreas has copyright ownership
or if RH slurped all that up -- the commits are from his @redhat.com
email. I was about to resend the series so I'll cc him on it.
--D
prev parent reply other threads:[~2019-07-15 17:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 17:01 [PATCH RFC 00/11] iomap: regroup code by functional area Darrick J. Wong
2019-07-01 17:02 ` [PATCH 01/11] iomap: start moving code to fs/iomap/ Darrick J. Wong
2019-07-01 17:02 ` [PATCH 02/11] iomap: move the swapfile code into a separate file Darrick J. Wong
2019-07-01 17:02 ` [PATCH 03/11] iomap: move the file mapping reporting " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 04/11] iomap: move the SEEK_HOLE " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 05/11] iomap: move the direct IO " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 06/11] iomap: move the buffered write " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 07/11] iomap: move the buffered read " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 08/11] iomap: move the page management " Darrick J. Wong
2019-07-01 17:02 ` [PATCH 09/11] iomap: move the page migration " Darrick J. Wong
2019-07-01 17:03 ` [PATCH 10/11] iomap: move the main iteration " Darrick J. Wong
2019-07-01 17:03 ` [PATCH 11/11] iomap: move internal declarations into fs/iomap/ Darrick J. Wong
2019-07-01 17:41 ` [PATCH RFC 00/11] iomap: regroup code by functional area Theodore Ts'o
2019-07-01 17:59 ` Darrick J. Wong
2019-07-08 18:46 ` Christoph Hellwig
2019-07-09 16:49 ` Darrick J. Wong
2019-07-09 18:12 ` Christoph Hellwig
2019-07-15 16:43 ` Darrick J. Wong
2019-07-15 16:50 ` Christoph Hellwig
2019-07-15 17:49 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715174944.GC6147@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).