From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
agruenba@redhat.com
Subject: Re: [PATCH 7/9] iomap: move the page migration code into a separate file
Date: Tue, 16 Jul 2019 22:53:58 -0700 [thread overview]
Message-ID: <20190717055358.GB7093@magnolia> (raw)
In-Reply-To: <20190717050503.GG7113@infradead.org>
On Tue, Jul 16, 2019 at 10:05:03PM -0700, Christoph Hellwig wrote:
> I wonder if this should go with the rest of the buffered I/O code into
> buffered-io.c? Yes, it would need an ifdef, but it is closely related
> to it in how we use the page private information.
Hmmm, I suppose the fact that we need a page migration function that
moves page_private from one page to another reflects what we do with
pages, even though we don't explicitly dereference the page private
pointer itself.
> > diff --git a/fs/iomap/migrate.c b/fs/iomap/migrate.c
> > new file mode 100644
> > index 000000000000..d8116d35f819
> > --- /dev/null
> > +++ b/fs/iomap/migrate.c
> > @@ -0,0 +1,39 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (C) 2010 Red Hat, Inc.
> > + * Copyright (c) 2016-2018 Christoph Hellwig.
> > + */
>
> Bit if you don't want to move it, this is all new code from me from
> 2018.
Ok, will shove it all into buffered-io.c then.
--D
next prev parent reply other threads:[~2019-07-17 5:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 17:59 [PATCH v2 0/9] iomap: regroup code by functional area Darrick J. Wong
2019-07-15 17:59 ` [PATCH 1/9] iomap: start moving code to fs/iomap/ Darrick J. Wong
2019-07-17 4:59 ` Christoph Hellwig
2019-07-17 5:26 ` Darrick J. Wong
2019-07-15 17:59 ` [PATCH 2/9] iomap: move the swapfile code into a separate file Darrick J. Wong
2019-07-17 4:59 ` Christoph Hellwig
2019-07-15 17:59 ` [PATCH 3/9] iomap: move the file mapping reporting " Darrick J. Wong
2019-07-17 4:59 ` Christoph Hellwig
2019-07-15 17:59 ` [PATCH 4/9] iomap: move the SEEK_HOLE " Darrick J. Wong
2019-07-17 5:01 ` Christoph Hellwig
2019-07-17 12:44 ` Andreas Gruenbacher
2019-07-17 14:53 ` Darrick J. Wong
2019-07-15 17:59 ` [PATCH 5/9] iomap: move the direct IO " Darrick J. Wong
2019-07-17 5:02 ` Christoph Hellwig
2019-07-15 17:59 ` [PATCH 6/9] iomap: move the buffered " Darrick J. Wong
2019-07-17 5:03 ` Christoph Hellwig
2019-07-15 18:00 ` [PATCH 7/9] iomap: move the page migration " Darrick J. Wong
2019-07-17 5:05 ` Christoph Hellwig
2019-07-17 5:53 ` Darrick J. Wong [this message]
2019-07-15 18:00 ` [PATCH 8/9] iomap: move the main iteration " Darrick J. Wong
2019-07-17 5:05 ` Christoph Hellwig
2019-07-15 18:00 ` [PATCH 9/9] iomap: move internal declarations into fs/iomap/ Darrick J. Wong
2019-07-17 5:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717055358.GB7093@magnolia \
--to=darrick.wong@oracle.com \
--cc=agruenba@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).