From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 4/9] iomap: move the SEEK_HOLE code into a separate file
Date: Wed, 17 Jul 2019 07:53:35 -0700 [thread overview]
Message-ID: <20190717145335.GD7093@magnolia> (raw)
In-Reply-To: <CAHc6FU7A3U1FZXwXfvJRL1FazUu=zfJ4=AwpggNG5QWvsywt2A@mail.gmail.com>
On Wed, Jul 17, 2019 at 02:44:20PM +0200, Andreas Gruenbacher wrote:
> On Wed, 17 Jul 2019 at 07:01, Christoph Hellwig <hch@infradead.org> wrote:
> > > diff --git a/fs/iomap/seek.c b/fs/iomap/seek.c
> > > new file mode 100644
> > > index 000000000000..0c36bef46522
> > > --- /dev/null
> > > +++ b/fs/iomap/seek.c
> > > @@ -0,0 +1,214 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Copyright (C) 2010 Red Hat, Inc.
> > > + * Copyright (c) 2016-2018 Christoph Hellwig.
> > > + */
> >
> > This looks a little odd. There is nothing in here from Daves original
> > iomap prototype. It did start out with code from Andreas though which
> > might or might not be RH copyright. So we'll need Andreas and/or RH
> > legal to chime in.
>
> That code should be Copyright (C) 2017 Red Hat, Inc.
Ok, fixed.
--D
> > Otherwise looks good:
> >
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Thanks,
> Andreas
next prev parent reply other threads:[~2019-07-17 14:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 17:59 [PATCH v2 0/9] iomap: regroup code by functional area Darrick J. Wong
2019-07-15 17:59 ` [PATCH 1/9] iomap: start moving code to fs/iomap/ Darrick J. Wong
2019-07-17 4:59 ` Christoph Hellwig
2019-07-17 5:26 ` Darrick J. Wong
2019-07-15 17:59 ` [PATCH 2/9] iomap: move the swapfile code into a separate file Darrick J. Wong
2019-07-17 4:59 ` Christoph Hellwig
2019-07-15 17:59 ` [PATCH 3/9] iomap: move the file mapping reporting " Darrick J. Wong
2019-07-17 4:59 ` Christoph Hellwig
2019-07-15 17:59 ` [PATCH 4/9] iomap: move the SEEK_HOLE " Darrick J. Wong
2019-07-17 5:01 ` Christoph Hellwig
2019-07-17 12:44 ` Andreas Gruenbacher
2019-07-17 14:53 ` Darrick J. Wong [this message]
2019-07-15 17:59 ` [PATCH 5/9] iomap: move the direct IO " Darrick J. Wong
2019-07-17 5:02 ` Christoph Hellwig
2019-07-15 17:59 ` [PATCH 6/9] iomap: move the buffered " Darrick J. Wong
2019-07-17 5:03 ` Christoph Hellwig
2019-07-15 18:00 ` [PATCH 7/9] iomap: move the page migration " Darrick J. Wong
2019-07-17 5:05 ` Christoph Hellwig
2019-07-17 5:53 ` Darrick J. Wong
2019-07-15 18:00 ` [PATCH 8/9] iomap: move the main iteration " Darrick J. Wong
2019-07-17 5:05 ` Christoph Hellwig
2019-07-15 18:00 ` [PATCH 9/9] iomap: move internal declarations into fs/iomap/ Darrick J. Wong
2019-07-17 5:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717145335.GD7093@magnolia \
--to=darrick.wong@oracle.com \
--cc=agruenba@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).