From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CE87C76188 for ; Mon, 22 Jul 2019 12:11:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FFEE2190D for ; Mon, 22 Jul 2019 12:11:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729193AbfGVMLP (ORCPT ); Mon, 22 Jul 2019 08:11:15 -0400 Received: from mga14.intel.com ([192.55.52.115]:23024 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727164AbfGVMLO (ORCPT ); Mon, 22 Jul 2019 08:11:14 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jul 2019 05:11:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,295,1559545200"; d="scan'208";a="180378524" Received: from khuang2-desk.gar.corp.intel.com ([10.254.182.119]) by orsmga002.jf.intel.com with ESMTP; 22 Jul 2019 05:11:12 -0700 From: Kai Huang To: viro@ZenIV.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Kai Huang Subject: [PATCH] anon_inodes: remove redundant file->f_mapping initialization Date: Tue, 23 Jul 2019 00:09:58 +1200 Message-Id: <20190722120958.9179-1-kai.huang@linux.intel.com> X-Mailer: git-send-email 2.13.6 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org In anon_inode_getfile(), file->f_mapping is redundantly initialized to anon_inode_inode->i_mapping, since it has already been initialized in alloc_file_pseudo() -> alloc_file(), so remove the initialization in anon_inode_getfile(). Signed-off-by: Kai Huang --- fs/anon_inodes.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c index 89714308c25b..b8b77066a1b9 100644 --- a/fs/anon_inodes.c +++ b/fs/anon_inodes.c @@ -93,8 +93,6 @@ struct file *anon_inode_getfile(const char *name, if (IS_ERR(file)) goto err; - file->f_mapping = anon_inode_inode->i_mapping; - file->private_data = priv; return file; -- 2.13.6