From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D80F9C41514 for ; Mon, 5 Aug 2019 18:03:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A28020B1F for ; Mon, 5 Aug 2019 18:03:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728851AbfHESDE (ORCPT ); Mon, 5 Aug 2019 14:03:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39366 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728518AbfHESDD (ORCPT ); Mon, 5 Aug 2019 14:03:03 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 79A5930224AC; Mon, 5 Aug 2019 18:03:03 +0000 (UTC) Received: from bfoster (dhcp-41-2.bos.redhat.com [10.18.41.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF9065C1D4; Mon, 5 Aug 2019 18:03:02 +0000 (UTC) Date: Mon, 5 Aug 2019 14:03:01 -0400 From: Brian Foster To: Dave Chinner Cc: linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 15/24] xfs: eagerly free shadow buffers to reduce CIL footprint Message-ID: <20190805180300.GE14760@bfoster> References: <20190801021752.4986-1-david@fromorbit.com> <20190801021752.4986-16-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190801021752.4986-16-david@fromorbit.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Mon, 05 Aug 2019 18:03:03 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Aug 01, 2019 at 12:17:43PM +1000, Dave Chinner wrote: > From: Dave Chinner > > The CIL can pin a lot of memory and effectively defines the lower > free memory boundary of operation for XFS. The way we hang onto > log item shadow buffers "just in case" effectively doubles the > memory footprint of the CIL for dubious reasons. > > That is, we hang onto the old shadow buffer in case the next time > we log the item it will fit into the shadow buffer and we won't have > to allocate a new one. However, we only ever tend to grow dirty > objects in the CIL through relogging, so once we've allocated a > larger buffer the old buffer we set as a shadow buffer will never > get reused as the amount we log never decreases until the item is > clean. And then for buffer items we free the log item and the shadow > buffers, anyway. Inode items will hold onto their shadow buffer > until they are reclaimed - this could double the inode's memory > footprint for it's lifetime... > > Hence we should just free the old log item buffer when we replace it > with a new shadow buffer rather than storing it for later use. It's > not useful, get rid of it as early as possible. > > Signed-off-by: Dave Chinner > --- > fs/xfs/xfs_log_cil.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c > index fa5602d0fd7f..1863a9bdf4a9 100644 > --- a/fs/xfs/xfs_log_cil.c > +++ b/fs/xfs/xfs_log_cil.c > @@ -238,9 +238,7 @@ xfs_cil_prepare_item( > /* > * If there is no old LV, this is the first time we've seen the item in > * this CIL context and so we need to pin it. If we are replacing the > - * old_lv, then remove the space it accounts for and make it the shadow > - * buffer for later freeing. In both cases we are now switching to the > - * shadow buffer, so update the the pointer to it appropriately. > + * old_lv, then remove the space it accounts for and free it. > */ The comment above xlog_cil_alloc_shadow_bufs() needs a similar update around how we handle the old buffer when the shadow buffer is used. > if (!old_lv) { > if (lv->lv_item->li_ops->iop_pin) > @@ -251,7 +249,8 @@ xfs_cil_prepare_item( > > *diff_len -= old_lv->lv_bytes; > *diff_iovecs -= old_lv->lv_niovecs; > - lv->lv_item->li_lv_shadow = old_lv; > + kmem_free(old_lv); > + lv->lv_item->li_lv_shadow = NULL; > } So IIUC this is the case where we allocated a shadow buffer, the item was already pinned (so old_lv is still around) but we ended up using the shadow buffer for this relog. Instead of keeping the old buffer around as a new shadow, we toss it. That makes sense, but if the objective is to not leave dangling shadow buffers around as such, what about the case where we allocated a shadow buffer but didn't end up using it because old_lv was reusable? It looks like we still keep the shadow buffer around in that scenario with a similar lifetime as the swapout scenario this patch removes. Hm? Brian > > /* attach new log vector to log item */ > -- > 2.22.0 >