From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C9FEC433FF for ; Tue, 6 Aug 2019 05:34:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C7B820665 for ; Tue, 6 Aug 2019 05:34:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726243AbfHFFe2 (ORCPT ); Tue, 6 Aug 2019 01:34:28 -0400 Received: from verein.lst.de ([213.95.11.211]:53243 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726036AbfHFFe2 (ORCPT ); Tue, 6 Aug 2019 01:34:28 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id E8D5268B05; Tue, 6 Aug 2019 07:34:25 +0200 (CEST) Date: Tue, 6 Aug 2019 07:34:25 +0200 From: Christoph Hellwig To: "Darrick J. Wong" , hch@infradead.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Damien.LeMoal@wdc.com, Christoph Hellwig , agruenba@redhat.com Subject: Re: [PATCH 1/5] xfs: use a struct iomap in xfs_writepage_ctx Message-ID: <20190806053425.GG13409@lst.de> References: <156444951713.2682520.8109813555788585092.stgit@magnolia> <156444952349.2682520.6180005494290997205.stgit@magnolia> <20190805123826.6bv7jhcnw5ecnol7@orion.maiolino.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190805123826.6bv7jhcnw5ecnol7@orion.maiolino.org> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Aug 05, 2019 at 02:38:26PM +0200, Carlos Maiolino wrote: > > - * Attempt to allocate whatever delalloc extent currently backs > > - * offset_fsb and put the result into wpc->imap. Allocate in a loop > > - * because it may take several attempts to allocate real blocks for a > > - * contiguous delalloc extent if free space is sufficiently fragmented. > > + * Attempt to allocate whatever delalloc extent currently backs offset > > + * and put the result into wpc->imap. Allocate in a loop because it may > ^^^^ > And put the result into wpc->iomap? Yes. Darrick, can you fix this up when applying?