From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25DFDC433FF for ; Tue, 6 Aug 2019 12:53:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 011C320B1F for ; Tue, 6 Aug 2019 12:53:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730188AbfHFMxZ (ORCPT ); Tue, 6 Aug 2019 08:53:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54826 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728560AbfHFMxZ (ORCPT ); Tue, 6 Aug 2019 08:53:25 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 197BC30A542E; Tue, 6 Aug 2019 12:53:24 +0000 (UTC) Received: from bfoster (dhcp-41-2.bos.redhat.com [10.18.41.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8E8FC6092D; Tue, 6 Aug 2019 12:53:23 +0000 (UTC) Date: Tue, 6 Aug 2019 08:53:21 -0400 From: Brian Foster To: Dave Chinner Cc: linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 14/24] xfs: tail updates only need to occur when LSN changes Message-ID: <20190806125321.GC2979@bfoster> References: <20190801021752.4986-1-david@fromorbit.com> <20190801021752.4986-15-david@fromorbit.com> <20190805175325.GD14760@bfoster> <20190805232826.GZ7777@dread.disaster.area> <20190806053338.GD7777@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190806053338.GD7777@dread.disaster.area> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Tue, 06 Aug 2019 12:53:24 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Aug 06, 2019 at 03:33:38PM +1000, Dave Chinner wrote: > On Tue, Aug 06, 2019 at 09:28:26AM +1000, Dave Chinner wrote: > > On Mon, Aug 05, 2019 at 01:53:26PM -0400, Brian Foster wrote: > > > On Thu, Aug 01, 2019 at 12:17:42PM +1000, Dave Chinner wrote: > > > > From: Dave Chinner > > > > > > > > We currently wake anything waiting on the log tail to move whenever > > > > the log item at the tail of the log is removed. Historically this > > > > was fine behaviour because there were very few items at any given > > > > LSN. But with delayed logging, there may be thousands of items at > > > > any given LSN, and we can't move the tail until they are all gone. > > > > > > > > Hence if we are removing them in near tail-first order, we might be > > > > waking up processes waiting on the tail LSN to change (e.g. log > > > > space waiters) repeatedly without them being able to make progress. > > > > This also occurs with the new sync push waiters, and can result in > > > > thousands of spurious wakeups every second when under heavy direct > > > > reclaim pressure. > > > > > > > > To fix this, check that the tail LSN has actually changed on the > > > > AIL before triggering wakeups. This will reduce the number of > > > > spurious wakeups when doing bulk AIL removal and make this code much > > > > more efficient. > > > > > > > > XXX: occasionally get a temporary hang in xfs_ail_push_sync() with > > > > this change - log force from log worker gets things moving again. > > > > Only happens under extreme memory pressure - possibly push racing > > > > with a tail update on an empty log. Needs further investigation. > > > > > > > > Signed-off-by: Dave Chinner > > > > --- > > > > > > Ok, this addresses the wakeup granularity issue mentioned in the > > > previous patch. Note that I was kind of wondering why we wouldn't base > > > this on the l_tail_lsn update in xlog_assign_tail_lsn_locked() as > > > opposed to the current approach. > > > > Because I didn't think of it? :) > > > > There's so much other stuff in this patch set I didn't spend a > > lot of time thinking about other alternatives. this was a simple > > code transformation that did what I wanted, and I went on to burning > > brain cells on other more complex issues that needs to be solved... > > > > > For example, xlog_assign_tail_lsn_locked() could simply check the > > > current min item against the current l_tail_lsn before it does the > > > assignment and use that to trigger tail change events. If we wanted to > > > also filter out the other wakeups (as this patch does) then we could > > > just pass a bool pointer or something that returns whether the tail > > > actually changed. > > > > Yeah, I'll have a look at this - I might rework it as additional > > patches now the code is looking at decisions based on LSN rather > > than if the tail log item changed... > > Ok, this is not worth the complexity. The wakeup code has to be able > to tell the difference between a changed tail lsn and an empty AIL > so that wakeups can be issued when the AIL is finally emptied. > Unmount (xfs_ail_push_all_sync()) relies on this, and > xlog_assign_tail_lsn_locked() hides the empty AIL from the caller > by returning log->l_last_sync_lsn to the caller. > Wouldn't either case just be a wakeup from xlog_assign_tail_lsn_locked() (which should probably be renamed if we took that approach)? It's called when we've removed the min item from the AIL and so potentially need to update the tail lsn. > Hence the wakeup code still has to check for an empty AIL if the > tail has changed if we use the return value of > xlog_assign_tail_lsn_locked() as the tail LSN. At which point, the > logic becomes somewhat convoluted, and it's far simpler to use > __xfs_ail_min_lsn as it returns when the log is empty. > > So, nice idea, but it doesn't make the code simpler or easier to > understand.... > It's not that big of a deal either way. BTW on another quick look, I think something like xfs_ail_update_tail(ailp, old_tail) is a bit more self-documenting that xfs_ail_delete_finish(ailp, old_lsn). Brian > Cheers, > > Dave. > -- > Dave Chinner > david@fromorbit.com