From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 181E8C433FF for ; Tue, 6 Aug 2019 21:06:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFC0C20B1F for ; Tue, 6 Aug 2019 21:06:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726069AbfHFVG0 (ORCPT ); Tue, 6 Aug 2019 17:06:26 -0400 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:46573 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726016AbfHFVG0 (ORCPT ); Tue, 6 Aug 2019 17:06:26 -0400 Received: from dread.disaster.area (pa49-181-167-148.pa.nsw.optusnet.com.au [49.181.167.148]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id B989243CF0A; Wed, 7 Aug 2019 07:06:22 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92) (envelope-from ) id 1hv6dv-00051f-48; Wed, 07 Aug 2019 07:05:15 +1000 Date: Wed, 7 Aug 2019 07:05:15 +1000 From: Dave Chinner To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 12/24] xfs: correctly acount for reclaimable slabs Message-ID: <20190806210515.GF7777@dread.disaster.area> References: <20190801021752.4986-1-david@fromorbit.com> <20190801021752.4986-13-david@fromorbit.com> <20190806055249.GB25736@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190806055249.GB25736@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=D+Q3ErZj c=1 sm=1 tr=0 cx=a_idp_d a=gu9DDhuZhshYSb5Zs/lkOA==:117 a=gu9DDhuZhshYSb5Zs/lkOA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=FmdZ9Uzk2mMA:10 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=hgB5nrfzdG2RuRxMWyMA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Aug 05, 2019 at 10:52:49PM -0700, Christoph Hellwig wrote: > On Thu, Aug 01, 2019 at 12:17:40PM +1000, Dave Chinner wrote: > > From: Dave Chinner > > > > The XFS inode item slab actually reclaimed by inode shrinker > > callbacks from the memory reclaim subsystem. These should be marked > > as reclaimable so the mm subsystem has the full picture of how much > > memory it can actually reclaim from the XFS slab caches. > > Looks good, > > Reviewed-by: Christoph Hellwig > > Btw, I wonder if we should just kill off our KM_ZONE_* defined. They > just make it a little harder to figure out what is actually going on > without a real benefit. Yeah, they don't serve much purpose now, it might be worth cleaning up. Cheers, Dave. -- Dave Chinner david@fromorbit.com