From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9707DC32750 for ; Tue, 13 Aug 2019 05:57:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B53020840 for ; Tue, 13 Aug 2019 05:57:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565675833; bh=FyGUGMmt6VbbQd/XPCpah8cHXNq/mUzxgtr490TM5WA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=ma0Wdcfw4Foi91Lk2HWmQlPOCj9+tw2QqXaaOvaJJ26Cc8YPoIvgdZcNlbFK1kW+7 meWabhIdpOJ5LMq8ClKStA/6EarMOnfHCdUEi4gMcrqUBptooexPqpFCzQ/2/i/Qml 7ciCQmsDiT10CeCpx3ndHjmKlQPiChMsQFcRvz0U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726785AbfHMF5J (ORCPT ); Tue, 13 Aug 2019 01:57:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:42848 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbfHMF5I (ORCPT ); Tue, 13 Aug 2019 01:57:08 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8B2BB206C2; Tue, 13 Aug 2019 05:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565675827; bh=FyGUGMmt6VbbQd/XPCpah8cHXNq/mUzxgtr490TM5WA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=ozCoFjdxFrUh5LQxMnAtmWn3xu8MGm+3oEgO4YFweTz+BBIbWxX5rPJEIqeQ7XIte ULgzVckj3NDd47TQ8NJczzulniOe62Jxa8qjpvHzK5dOOwZuG9dYrC1oX/YMzL6A1L EcSDLC5VAWszW8A7ahShAkQ2OWzEn+8uo7cZUSzE= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20190812182421.141150-1-brendanhiggins@google.com> <20190812182421.141150-11-brendanhiggins@google.com> <20190813042455.4A04320644@mail.kernel.org> Subject: Re: [PATCH v12 10/18] kunit: test: add tests for kunit test abort From: Stephen Boyd Cc: Frank Rowand , Greg KH , Josh Poimboeuf , Kees Cook , Kieran Bingham , Luis Chamberlain , Peter Zijlstra , Rob Herring , shuah , Theodore Ts'o , Masahiro Yamada , devicetree , dri-devel , kunit-dev@googlegroups.com, "open list:DOCUMENTATION" , linux-fsdevel@vger.kernel.org, linux-kbuild , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , "Bird, Timothy" , Amir Goldstein , Dan Carpenter , Daniel Vetter , Jeff Dike , Joel Stanley , Julia Lawall , Kevin Hilman , Knut Omang , Logan Gunthorpe , Michael Ellerman , Petr Mladek , Randy Dunlap , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com To: Brendan Higgins User-Agent: alot/0.8.1 Date: Mon, 12 Aug 2019 22:57:06 -0700 Message-Id: <20190813055707.8B2BB206C2@mail.kernel.org> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Quoting Brendan Higgins (2019-08-12 22:06:04) > On Mon, Aug 12, 2019 at 9:24 PM Stephen Boyd wrote: > > > > Quoting Brendan Higgins (2019-08-12 11:24:13) > > > + > > > +static int kunit_try_catch_test_init(struct kunit *test) > > > +{ > > > + struct kunit_try_catch_test_context *ctx; > > > + > > > + ctx =3D kunit_kzalloc(test, sizeof(*ctx), GFP_KERNEL); > > > > Can this fail? Should return -ENOMEM in that case? >=20 > Yes, I should do that. Looks like it's asserted to not be an error. If it's pushed into the API then there's nothing to do here, and you can have my reviewed-by on this patch. Reviewed-by: Stephen Boyd