From: kbuild test robot <lkp@intel.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: kbuild-all@01.org, linux-fsdevel@vger.kernel.org,
linux-mtd@lists.infradead.org, Jan Kara <jack@suse.com>,
Richard Weinberger <richard@nod.at>,
kernel@pengutronix.de, Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH 05/11] quota: Allow to pass quotactl a mountpoint
Date: Thu, 15 Aug 2019 06:42:59 +0800 [thread overview]
Message-ID: <201908150625.uw91igqr%lkp@intel.com> (raw)
In-Reply-To: <20190814121834.13983-6-s.hauer@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 5320 bytes --]
Hi Sascha,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc4 next-20190814]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Sascha-Hauer/Add-quota-support-to-UBIFS/20190815-010732
config: i386-randconfig-a002-201932 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
fs/quota/quota.c: In function 'quotactl_get_super':
fs/quota/quota.c:838:13: error: implicit declaration of function 'quotactl_cmd_write'; did you mean 'quotactl_cmd_onoff'? [-Werror=implicit-function-declaration]
} else if (quotactl_cmd_write(cmd)) {
^~~~~~~~~~~~~~~~~~
quotactl_cmd_onoff
fs/quota/quota.c: In function 'kernel_quotactl':
>> fs/quota/quota.c:853:7: warning: 'exclusive' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (exclusive)
^
fs/quota/quota.c:832:23: note: 'exclusive' was declared here
bool thawed = false, exclusive;
^~~~~~~~~
cc1: some warnings being treated as errors
vim +/exclusive +853 fs/quota/quota.c
ab9c4e200cc992 fs/quota/quota.c Sascha Hauer 2019-08-14 824
^1da177e4c3f41 fs/quota.c Linus Torvalds 2005-04-16 825 /*
9361401eb7619c fs/quota.c David Howells 2006-09-30 826 * look up a superblock on which quota ops will be performed
9361401eb7619c fs/quota.c David Howells 2006-09-30 827 * - use the name of a block device to find the superblock thereon
9361401eb7619c fs/quota.c David Howells 2006-09-30 828 */
ab9c4e200cc992 fs/quota/quota.c Sascha Hauer 2019-08-14 829 static struct super_block *quotactl_get_super(const char __user *special, int cmd)
9361401eb7619c fs/quota.c David Howells 2006-09-30 830 {
9361401eb7619c fs/quota.c David Howells 2006-09-30 831 struct super_block *sb;
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 832 bool thawed = false, exclusive;
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 833 int ret;
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 834
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 835 if (quotactl_cmd_onoff(cmd)) {
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 836 thawed = true;
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 837 exclusive = true;
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 @838 } else if (quotactl_cmd_write(cmd)) {
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 839 thawed = true;
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 840 exclusive = false;
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 841 }
9361401eb7619c fs/quota.c David Howells 2006-09-30 842
ab9c4e200cc992 fs/quota/quota.c Sascha Hauer 2019-08-14 843 sb = quotactl_block(special);
ab9c4e200cc992 fs/quota/quota.c Sascha Hauer 2019-08-14 844 if (IS_ERR(sb)) {
ab9c4e200cc992 fs/quota/quota.c Sascha Hauer 2019-08-14 845 sb = quotactl_path(special);
ab9c4e200cc992 fs/quota/quota.c Sascha Hauer 2019-08-14 846 if (IS_ERR(sb))
ab9c4e200cc992 fs/quota/quota.c Sascha Hauer 2019-08-14 847 return ERR_CAST(sb);
ab9c4e200cc992 fs/quota/quota.c Sascha Hauer 2019-08-14 848 }
9361401eb7619c fs/quota.c David Howells 2006-09-30 849
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 850 if (thawed) {
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 851 ret = wait_super_thawed(sb, exclusive);
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 852 if (ret) {
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 @853 if (exclusive)
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 854 drop_super_exclusive(sb);
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 855 else
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 856 drop_super(sb);
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 857 return ERR_PTR(ret);
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 858 }
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 859 }
335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 860
9361401eb7619c fs/quota.c David Howells 2006-09-30 861 return sb;
9361401eb7619c fs/quota.c David Howells 2006-09-30 862 }
9361401eb7619c fs/quota.c David Howells 2006-09-30 863
:::::: The code at line 853 was first introduced by commit
:::::: 335508f54c9cd0c8589271420bee8a38cff13ed5 fs, quota: introduce wait_super_thawed() to wait until a superblock is thawed
:::::: TO: Sascha Hauer <s.hauer@pengutronix.de>
:::::: CC: 0day robot <lkp@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34608 bytes --]
next prev parent reply other threads:[~2019-08-14 22:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 12:18 [PATCH 00/11] Add quota support to UBIFS Sascha Hauer
2019-08-14 12:18 ` [PATCH 01/11] quota: Make inode optional Sascha Hauer
2019-08-14 12:18 ` [PATCH 02/11] quota: Only module_put the format when existing Sascha Hauer
2019-08-15 11:18 ` Jan Kara
2019-08-16 11:49 ` Sascha Hauer
2019-08-14 12:18 ` [PATCH 03/11] fs: move __get_super() out of loop Sascha Hauer
2019-08-14 23:32 ` Al Viro
2019-08-14 12:18 ` [PATCH 04/11] fs, quota: introduce wait_super_thawed() to wait until a superblock is thawed Sascha Hauer
2019-08-14 23:35 ` Al Viro
2019-08-14 12:18 ` [PATCH 05/11] quota: Allow to pass quotactl a mountpoint Sascha Hauer
2019-08-14 22:42 ` kbuild test robot [this message]
2019-08-14 23:33 ` kbuild test robot
2019-08-14 23:36 ` Al Viro
2019-08-14 23:39 ` Al Viro
2019-08-14 23:51 ` Al Viro
2019-08-15 9:53 ` Jan Kara
2019-08-15 7:46 ` Sascha Hauer
2019-08-14 12:18 ` [PATCH 06/11] ubifs: move checks and preparation into setflags() Sascha Hauer
2019-08-14 12:18 ` [PATCH 07/11] ubifs: Add support for FS_IOC_FS[SG]ETXATTR ioctls Sascha Hauer
2019-08-14 14:11 ` Mainz, Roland
2019-08-15 7:31 ` Sascha Hauer
2019-08-14 12:18 ` [PATCH 08/11] ubifs: do not ubifs_inode() on potentially NULL pointer Sascha Hauer
2019-08-14 12:18 ` [PATCH 09/11] ubifs: Add support for project id Sascha Hauer
2019-08-14 12:18 ` [PATCH 10/11] ubifs: export get_znode Sascha Hauer
2019-08-14 12:18 ` [PATCH 11/11] ubifs: Add quota support Sascha Hauer
2019-08-15 11:17 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201908150625.uw91igqr%lkp@intel.com \
--to=lkp@intel.com \
--cc=jack@suse.com \
--cc=kbuild-all@01.org \
--cc=kernel@pengutronix.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).