From: Oleksandr Natalenko <oleksandr@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org,
Christian Brauner <christian@brauner.io>,
Seth Forshee <seth.forshee@canonical.com>,
Stefan Bader <stefan.bader@canonical.com>,
Kleber Sacilotto de Souza <kleber.souza@canonical.com>,
Tyler Hicks <tyhicks@canonical.com>,
Marcelo Henrique Cerri <marcelo.cerri@canonical.com>,
Brad Figg <brad.figg@canonical.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>
Subject: [PATCH 1/1] shiftfs-5.2: use copy_from_user() correctly
Date: Thu, 15 Aug 2019 16:36:03 +0200 [thread overview]
Message-ID: <20190815143603.17127-2-oleksandr@redhat.com> (raw)
In-Reply-To: <20190815143603.17127-1-oleksandr@redhat.com>
Signed-off-by: Oleksandr Natalenko <oleksandr@redhat.com>
---
fs/shiftfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/shiftfs.c b/fs/shiftfs.c
index 49f6714e9f95..14f3764577d8 100644
--- a/fs/shiftfs.c
+++ b/fs/shiftfs.c
@@ -1526,7 +1526,7 @@ static bool in_ioctl_whitelist(int flag, unsigned long arg)
case BTRFS_IOC_SUBVOL_GETFLAGS:
return true;
case BTRFS_IOC_SUBVOL_SETFLAGS:
- if (copy_from_user(&flags, arg, sizeof(flags)))
+ if (copy_from_user(&flags, argp, sizeof(flags)))
return false;
if (flags & ~BTRFS_SUBVOL_RDONLY)
--
2.22.1
next prev parent reply other threads:[~2019-08-15 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 14:36 [PATCH 0/1] Small potential fix for shiftfs Oleksandr Natalenko
2019-08-15 14:36 ` Oleksandr Natalenko [this message]
2019-08-15 14:50 ` Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815143603.17127-2-oleksandr@redhat.com \
--to=oleksandr@redhat.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=brad.figg@canonical.com \
--cc=christian@brauner.io \
--cc=kleber.souza@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=seth.forshee@canonical.com \
--cc=stefan.bader@canonical.com \
--cc=tyhicks@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).