From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05327C3A59F for ; Thu, 29 Aug 2019 09:50:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D09E123403 for ; Thu, 29 Aug 2019 09:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567072227; bh=YDdsum+qhuDxQlXkQh1jgcwFqVQTWLCuOHt3KTVyJKw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Pa4OPkfWEtk0hn+QWTEJAicl5nmumgso+l0vUD1+ijkmO/Gvga+UD083XojpUECot ufkAd6LCAJLwhNiI+EjRCdvD1cEe5QJQnmnuY0y0htxwQXBiN3znid/0uPa9wwiSVT CA83csW847RWyQyiblH3mDzXuJQnY/nz0Kymcdfg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726245AbfH2JuX (ORCPT ); Thu, 29 Aug 2019 05:50:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:37626 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725990AbfH2JuX (ORCPT ); Thu, 29 Aug 2019 05:50:23 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1FB47233A1; Thu, 29 Aug 2019 09:50:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567072222; bh=YDdsum+qhuDxQlXkQh1jgcwFqVQTWLCuOHt3KTVyJKw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fe3cYth+gCYjtMMhkM4ZXG9SjtEc2qsZhNaJdn+1iJ4QonaeJAtVwsOOkTavtNzBW 559hW6GeJdnBDp8i8kXno7t/3PFHqDrV7SxzDEBEwu/WWJ12aEf7LTcsS0epSNYvHu uZRfd9v+PUCrGHh4n7uh6uEGyD8VLidiSH0temrQ= Date: Thu, 29 Aug 2019 11:50:19 +0200 From: Greg Kroah-Hartman To: Christoph Hellwig Cc: devel@driverdev.osuosl.org, Sasha Levin , Valdis =?utf-8?Q?Kl=C4=93tnieks?= , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, OGAWA Hirofumi Subject: Re: [PATCH] staging: exfat: add exfat filesystem code to staging Message-ID: <20190829095019.GA13557@kroah.com> References: <20190828160817.6250-1-gregkh@linuxfoundation.org> <20190828170022.GA7873@kroah.com> <20190829062340.GB3047@infradead.org> <20190829063955.GA30193@kroah.com> <20190829094136.GA28643@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190829094136.GA28643@infradead.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Aug 29, 2019 at 02:41:36AM -0700, Christoph Hellwig wrote: > On Thu, Aug 29, 2019 at 08:39:55AM +0200, Greg Kroah-Hartman wrote: > > On Wed, Aug 28, 2019 at 11:23:40PM -0700, Christoph Hellwig wrote: > > > Can we please just review the damn thing and get it into the proper > > > tree? That whole concept of staging file systems just has been one > > > fricking disaster, including Greg just moving not fully reviewed ones > > > over like erofs just because he feels like it. I'm getting sick and > > > tired of this scheme. > > > > For this filesystem, it's going to be a _lot_ of work before that can > > happen, and I'd really like to have lots of people help out with it > > instead of it living in random github trees for long periods of time. > > Did you actually look at the thing instead of blindly applying some > pile of crap? > > It basically is a reimplementation of fs/fat/ not up to kernel standards > with a few indirections thrown in to also support exfat. So no amount > of work on this codebase is really going to bring us forward. Instead > someone how can spend a couple days on this and actually has file > systems to test it just needs to bring the low-level format bits over > to our well tested fs/fat codebase instead of duplicating it. I did try just that, a few years ago, and gave up on it. I don't think it can be added to the existing vfat code base but I am willing to be proven wrong. Now that we have the specs, it might be easier, and the vfat spec is a subset of the exfat spec, but to get stuff working today, for users, it's good to have it in staging. We can do the normal, "keep it in stable, get a clean-room implementation merged like usual, and then delete the staging version" three step process like we have done a number of times already as well. I know the code is horrible, but I will gladly take horrible code into staging. If it bothers you, just please ignore it. That's what staging is there for :) thanks, greg k-h