From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D9C9C3A59F for ; Thu, 29 Aug 2019 11:18:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24CDF22CF5 for ; Thu, 29 Aug 2019 11:18:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567077525; bh=JQtNUh7qNDLWcxdyjDm3BBzByZeQKwMS+SSkLoxQodM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=noyqUos6WorlMmipJB0L1Jnm6vMDEsO+Bq0m9Xhs/ko8O0AO02IQ7E0bkXKzGdN42 Zm/QmXBvbmxekL0s7zPGqy1uDhjmPQar5+jrS6QyDBnVoZP70BSUfuC6WeEuNu5+hn 2tYXRX+wkTHrAGI+sYm9hepPRpwo0tPeNr0of1zE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726979AbfH2LSk (ORCPT ); Thu, 29 Aug 2019 07:18:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:50508 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbfH2LSk (ORCPT ); Thu, 29 Aug 2019 07:18:40 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5BE292189D; Thu, 29 Aug 2019 11:18:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567077519; bh=JQtNUh7qNDLWcxdyjDm3BBzByZeQKwMS+SSkLoxQodM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yqtbZ88ABfdZ9RN4GuefAC+ALscE6vMxl+0MPD59YrtSAr9Du5eDjuO1E162mutBg 7q8+OtpqhfroNvAuGOqGE2xjytsVqA6JFYCBJtekwFOfqDsUImnd8GylDlgZcSM4Yl YptKdYXQFKDVvuJLdhpL/dStQIy55eTjOUKom9gI= Date: Thu, 29 Aug 2019 13:18:37 +0200 From: Greg Kroah-Hartman To: Gao Xiang Cc: Christoph Hellwig , devel@driverdev.osuosl.org, Valdis =?utf-8?Q?Kl=C4=93tnieks?= , linux-kernel@vger.kernel.org, Sasha Levin , linux-fsdevel@vger.kernel.org, OGAWA Hirofumi Subject: Re: [PATCH] staging: exfat: add exfat filesystem code to staging Message-ID: <20190829111837.GB23393@kroah.com> References: <20190828160817.6250-1-gregkh@linuxfoundation.org> <20190828170022.GA7873@kroah.com> <20190829062340.GB3047@infradead.org> <20190829063955.GA30193@kroah.com> <20190829094136.GA28643@infradead.org> <20190829095019.GA13557@kroah.com> <20190829103749.GA13661@infradead.org> <20190829110443.GD64893@architecture4> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190829110443.GD64893@architecture4> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Aug 29, 2019 at 07:04:43PM +0800, Gao Xiang wrote: > On Thu, Aug 29, 2019 at 03:37:49AM -0700, Christoph Hellwig wrote: > > On Thu, Aug 29, 2019 at 11:50:19AM +0200, Greg Kroah-Hartman wrote: > > > I did try just that, a few years ago, and gave up on it. I don't think > > > it can be added to the existing vfat code base but I am willing to be > > > proven wrong. > > > > And what exactly was the problem? > > > > > > > > Now that we have the specs, it might be easier, and the vfat spec is a > > > subset of the exfat spec, but to get stuff working today, for users, > > > it's good to have it in staging. We can do the normal, "keep it in > > > stable, get a clean-room implementation merged like usual, and then > > > delete the staging version" three step process like we have done a > > > number of times already as well. > > > > > > I know the code is horrible, but I will gladly take horrible code into > > > staging. If it bothers you, just please ignore it. That's what staging > > > is there for :) > > > > And then after a while you decide it's been long enough and force move > > it out of staging like the POS erofs code? > > The problem is that EROFS has been there for a year and > I sent v1-v8 patches here, You didn't review or reply it > once until now. > > And I have no idea what is the relationship between EROFS > and the current exfat implementation. There isn't any, other than it too is a filesystem that was in the staging directory :) greg k-h