From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E4CC41514 for ; Fri, 30 Aug 2019 08:44:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DEA8C238C7 for ; Fri, 30 Aug 2019 08:44:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727739AbfH3Io2 (ORCPT ); Fri, 30 Aug 2019 04:44:28 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:3542 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727236AbfH3Io2 (ORCPT ); Fri, 30 Aug 2019 04:44:28 -0400 Received: from DGGEMM404-HUB.china.huawei.com (unknown [172.30.72.53]) by Forcepoint Email with ESMTP id B098D2181E2B1D99C5AA; Fri, 30 Aug 2019 16:44:22 +0800 (CST) Received: from dggeme762-chm.china.huawei.com (10.3.19.108) by DGGEMM404-HUB.china.huawei.com (10.3.20.212) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 30 Aug 2019 16:44:22 +0800 Received: from architecture4 (10.140.130.215) by dggeme762-chm.china.huawei.com (10.3.19.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Fri, 30 Aug 2019 16:44:21 +0800 Date: Fri, 30 Aug 2019 16:43:33 +0800 From: Gao Xiang To: Dan Carpenter CC: , Christoph Hellwig , Valdis =?gbk?Q?Kl=A8=A5tnieks?= , Greg Kroah-Hartman , , Sasha Levin , , "OGAWA Hirofumi" Subject: Re: [PATCH] staging: exfat: add exfat filesystem code to staging Message-ID: <20190830084333.GA193084@architecture4> References: <20190829094136.GA28643@infradead.org> <20190829095019.GA13557@kroah.com> <20190829103749.GA13661@infradead.org> <20190829111810.GA23393@kroah.com> <20190829151144.GJ23584@kadam> <20190829152757.GA125003@architecture4> <20190829154346.GK23584@kadam> <20190829155127.GA136563@architecture4> <20190829160441.GA141079@architecture4> <20190830083445.GL23584@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190830083445.GL23584@kadam> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [10.140.130.215] X-ClientProxiedBy: dggeme704-chm.china.huawei.com (10.1.199.100) To dggeme762-chm.china.huawei.com (10.3.19.108) X-CFilter-Loop: Reflected Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi Dan, On Fri, Aug 30, 2019 at 11:34:45AM +0300, Dan Carpenter wrote: > On Fri, Aug 30, 2019 at 12:04:41AM +0800, Gao Xiang wrote: > > Anyway, I'm fine to delete them all if you like, but I think majority of these > > are meaningful. > > > > data.c- /* page is already locked */ > > data.c- DBG_BUGON(PageUptodate(page)); > > data.c- > > data.c: if (unlikely(err)) > > data.c- SetPageError(page); > > data.c- else > > data.c- SetPageUptodate(page); > > If we cared about speed here then we would delete the DBG_BUGON() check > because that's going to be expensive. The likely/unlikely annotations > should be used in places a reasonable person thinks it will make a > difference to benchmarks. DBG_BUGON will be a no-op ((void)x) in non-debugging mode, I discussed related stuffs with Greg many months before [1] and other filesystems also have similar functions... p.s. I think we come to an agreement here... I killed all unlikely/likely. [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-November/128951.html sorry about no lore here. Thanks, Gao Xiang > > regards, > dan carpenter >