From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC7E9C3A5A8 for ; Sun, 1 Sep 2019 05:52:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9008A22CF7 for ; Sun, 1 Sep 2019 05:52:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aol.com header.i=@aol.com header.b="EchoCK6d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725928AbfIAFwA (ORCPT ); Sun, 1 Sep 2019 01:52:00 -0400 Received: from sonic313-21.consmr.mail.gq1.yahoo.com ([98.137.65.84]:46292 "EHLO sonic313-21.consmr.mail.gq1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725265AbfIAFwA (ORCPT ); Sun, 1 Sep 2019 01:52:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1567317119; bh=ngiBIgLQwzykiSUDwOXrihAxoles6AqD482llk2jyD8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject; b=EchoCK6drKyqLiGt9m40X/zvE9mgUTB7IR3RZy4rMS9npASfy4cHaRt4lytOQbk5xUoak2tEGGkJ+8VzmlXFQS7hPSs3lGpX+I+KbhyidIMHXk2h9c0UtQXmWQUiirizirSJeSpXfiDaqkjif3rq6w4QTl9AbJyaFOZMEBbOcL8pZbOnuFjfT5KhEwu/TlKWQvf6F+RhN1zZ6FJntT5IC9XPb9PdrkELqb3btxSd88qUEd8KpZ5vrDhFeiJTP9Cfstv0GLTUkztaiB5ssb+FppW9BR4EcTbseQ4B57hmiGca4v3DKpQCf+e7CIrY2ju1QRqlihCXAsigDJLDigORXA== X-YMail-OSG: gj6ee2EVM1k7lMxJPisAy8532wBcyUVBL3W_b036PmvPNzSd2Y4AivS_aB7hzhM wRO.70SaMKauFUiXa4wd5Da0uh9RL_AH35OUEPkjqDS2a_t9V_cJf0pCzmHB6IpJhoXCwRVusZFl Z9t_ydjMugmJ.mu42IJSC8TKiiC7kmyEcBml.C4uHXDFSkq8fAo1A9abdNuQ.jzcFBzhHTMuD_yk rwIi8mBWhB.zGAsvADH5boeM2z.H7F4xlSbJaobO6EGH5BbR3kGaa_kjDEtbECPoo.yDz5sWpeWF p6cjs82qXWR5YuuqVvcPB029MxDaJnkEtgeL3GhIAXNYK7bjMPcsZxgmljJP8RlzzeNeTAGgv5Nz m0v91e.5f5746da0vGED5.Jcj4SyA3IH5RtnsgABPiNkV_lPyen_2p2Nfyzj_gm5Yhrh7xkVnQYJ H.bnI_bD3n6B.whu89C99g912TET3SbDtBxvpGtrcUSdxS77RsTKlMqm5jgWRoUcy69eFUdsFQ57 bBMhgT0Q23Xmm.bxtHWL_BaxAt9F4uuTD2yAKEEJ92cnSCAUkd5DUjyigP8Vw9ciE4jZm8xtAOeu elN6Gxjvh8D5jWTcXvdy9r9QwLrSasF1JitPgTArWNUiulAeYgIb7k8mPV7f9ZVjZ_Kol.QmttfH Ff30CAq3vwmfC1nI1Co.5D5kDFwyYXZV8tIVheOXwWMvdOVunnO.EUK50Cq7zEW.J.yQkRtcT8vT BYVD0.3mTFn5m48LYoSh.6.8z.M.yW52V86lSiAdKWbskqht7ntueOvkxeKwPUONVwoakT9GyFFf 96hGM2Ykd6rsswIgd5ePulR7IBbNe4bBZ.J9P7tcz1OI_7a9_t65GdrhNFbZQonGlhM9RXvGujJK HGZslKCs42UsOc2WLOe46z_CM_eJo0CTL9gprJcuov_xXRSKPhz2s0YclXaRV7QJUqASkBziag1b 8jjI.4_zu9XWKMo.nOY.Dp6LXMXlRC3cVZwjaCUm2oQkojic.hRJN0BpUkE0XCGbEUgYj1sVWaD7 6aUnR2iXU8UcC6iqY8r55jz3jy_8iInotL_aDXTNpS79ZWLYxzK1_HzxAbnkLri83p_pV1vOILJ_ ETsb9eIO1AqoryEn_d9WKg5tIfvTKJZnqZMr9ryLpKZcx_4GvgRl5RCvHudApM.Pf8y2gPP0f5Ac xFDOHDzWd3Px204_fxLeTGodu81YFYP6T0aG7Tr0Hook5BxR6uhDsuLmTSWksjCHrytYIaL7uWSX UHt8.BdiigzpiDNC78APJIfb80ny73yt5dBMD9rA- Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Sun, 1 Sep 2019 05:51:59 +0000 Received: by smtp406.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 426e3b5ec1af9e36f409445c51071a70; Sun, 01 Sep 2019 05:51:57 +0000 (UTC) From: Gao Xiang To: Christoph Hellwig , Chao Yu , Greg Kroah-Hartman Cc: linux-fsdevel@vger.kernel.org, devel@driverdev.osuosl.org, linux-erofs@lists.ozlabs.org, Chao Yu , Gao Xiang Subject: [PATCH 02/21] erofs: on-disk format should have explicitly assigned numbers Date: Sun, 1 Sep 2019 13:51:11 +0800 Message-Id: <20190901055130.30572-3-hsiangkao@aol.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190901055130.30572-1-hsiangkao@aol.com> References: <20190802125347.166018-1-gaoxiang25@huawei.com> <20190901055130.30572-1-hsiangkao@aol.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org From: Gao Xiang As Christoph claimed [1], on-disk format should have explicitly assigned numbers. I have to change it. [1] https://lore.kernel.org/r/20190829095954.GB20598@infradead.org/ Reported-by: Christoph Hellwig Signed-off-by: Gao Xiang --- fs/erofs/erofs_fs.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/fs/erofs/erofs_fs.h b/fs/erofs/erofs_fs.h index 49335fff9d65..d1f152a3670a 100644 --- a/fs/erofs/erofs_fs.h +++ b/fs/erofs/erofs_fs.h @@ -53,10 +53,10 @@ struct erofs_super_block { * 4~7 - reserved */ enum { - EROFS_INODE_FLAT_PLAIN, - EROFS_INODE_FLAT_COMPRESSION_LEGACY, - EROFS_INODE_FLAT_INLINE, - EROFS_INODE_FLAT_COMPRESSION, + EROFS_INODE_FLAT_PLAIN = 0, + EROFS_INODE_FLAT_COMPRESSION_LEGACY = 1, + EROFS_INODE_FLAT_INLINE = 2, + EROFS_INODE_FLAT_COMPRESSION = 3, EROFS_INODE_LAYOUT_MAX }; @@ -184,7 +184,7 @@ struct erofs_xattr_entry { /* available compression algorithm types */ enum { - Z_EROFS_COMPRESSION_LZ4, + Z_EROFS_COMPRESSION_LZ4 = 0, Z_EROFS_COMPRESSION_MAX }; @@ -242,10 +242,10 @@ struct z_erofs_map_header { * (di_advise could be 0, 1 or 2) */ enum { - Z_EROFS_VLE_CLUSTER_TYPE_PLAIN, - Z_EROFS_VLE_CLUSTER_TYPE_HEAD, - Z_EROFS_VLE_CLUSTER_TYPE_NONHEAD, - Z_EROFS_VLE_CLUSTER_TYPE_RESERVED, + Z_EROFS_VLE_CLUSTER_TYPE_PLAIN = 0, + Z_EROFS_VLE_CLUSTER_TYPE_HEAD = 1, + Z_EROFS_VLE_CLUSTER_TYPE_NONHEAD = 2, + Z_EROFS_VLE_CLUSTER_TYPE_RESERVED = 3, Z_EROFS_VLE_CLUSTER_TYPE_MAX }; -- 2.17.1