From: Al Viro <viro@zeniv.linux.org.uk>
To: Qian Cai <cai@lca.pw>
Cc: linux-fsdevel@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: "fs/namei.c: keep track of nd->root refcount status" causes boot panic
Date: Tue, 3 Sep 2019 14:31:34 +0100 [thread overview]
Message-ID: <20190903133134.GG1131@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20190903123719.GF1131@ZenIV.linux.org.uk>
On Tue, Sep 03, 2019 at 01:37:19PM +0100, Al Viro wrote:
> On Tue, Sep 03, 2019 at 12:21:36AM -0400, Qian Cai wrote:
> > The linux-next commit "fs/namei.c: keep track of nd->root refcount status” [1] causes boot panic on all
> > architectures here on today’s linux-next (0902). Reverted it will fix the issue.
>
> <swearing>
>
> OK, I see what's going on. Incremental to be folded in:
... or, better yet,
diff --git a/include/linux/namei.h b/include/linux/namei.h
index 20ce2f917ef4..397a08ade6a2 100644
--- a/include/linux/namei.h
+++ b/include/linux/namei.h
@@ -37,7 +37,7 @@ enum {LAST_NORM, LAST_ROOT, LAST_DOT, LAST_DOTDOT, LAST_BIND};
#define LOOKUP_NO_REVAL 0x0080
#define LOOKUP_JUMPED 0x1000
#define LOOKUP_ROOT 0x2000
-#define LOOKUP_ROOT_GRABBED 0x4000
+#define LOOKUP_ROOT_GRABBED 0x0008
extern int path_pts(struct path *path);
to avoid breaking out-of-tree stuff for now good reason.
Folded and pushed out.
next prev parent reply other threads:[~2019-09-03 13:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 4:21 "fs/namei.c: keep track of nd->root refcount status" causes boot panic Qian Cai
2019-09-03 5:22 ` Dexuan-Linux Cui
2019-09-03 5:50 ` Dexuan Cui
2019-09-03 6:00 ` Dexuan Cui
2019-09-03 8:13 ` Naresh Kamboju
2019-09-03 9:08 ` Sachin Sant
2019-09-03 12:37 ` Al Viro
2019-09-03 13:04 ` Christoph Hellwig
2019-09-03 13:48 ` Al Viro
2019-09-03 13:50 ` Christoph Hellwig
2019-09-03 13:53 ` Al Viro
2019-09-03 15:39 ` Christoph Hellwig
2019-09-03 17:56 ` Al Viro
2019-09-04 12:39 ` Christoph Hellwig
2019-09-05 9:13 ` Naresh Kamboju
2019-09-05 16:46 ` Al Viro
2019-09-05 12:17 ` Kevin Easton
2019-09-03 21:30 ` Theodore Y. Ts'o
2019-09-03 13:31 ` Al Viro [this message]
2019-09-03 13:52 ` Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903133134.GG1131@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=cai@lca.pw \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).