From: Jan Kara <jack@suse.cz>
To: Matthew Wilcox <willy@infradead.org>
Cc: zhengbin <zhengbin13@huawei.com>,
amir73il@gmail.com, jack@suse.cz, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fanotify: remove always false comparison in copy_fid_to_user
Date: Tue, 3 Sep 2019 22:10:10 +0200 [thread overview]
Message-ID: <20190903201010.GA8225@quack2.suse.cz> (raw)
In-Reply-To: <20190903112818.GC29434@bombadil.infradead.org>
On Tue 03-09-19 04:28:21, Matthew Wilcox wrote:
> On Tue, Sep 03, 2019 at 09:54:14AM +0800, zhengbin wrote:
> > Fixes gcc warning:
> >
> > fs/notify/fanotify/fanotify_user.c:252:19: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: zhengbin <zhengbin13@huawei.com>
>
> When fixing bugs like this, please do a git log -p and cc the person
> responsible for introducing the code you're fixing. Also add a Fixes:
> line.
Generally I agree although in this particular case it is just a cosmetic
fix so I don't find that very important.
> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Thanks for review!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2019-09-03 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 1:54 [PATCH] fanotify: remove always false comparison in copy_fid_to_user zhengbin
2019-09-03 11:28 ` Matthew Wilcox
2019-09-03 20:10 ` Jan Kara [this message]
2019-09-03 11:40 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903201010.GA8225@quack2.suse.cz \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).