From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8877C43331 for ; Fri, 6 Sep 2019 02:59:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D10FD2082C for ; Fri, 6 Sep 2019 02:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567738758; bh=ACexdR+rY/Z3d3r2silQsTBU/Sic3Tj3n/fLXapx7Og=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Zup7uDps831hZaRzaR0K36PYVmm2WBOVD49Ab9KCdr3i0r0Ec/v7sRR3Ut9BKBDSu JReKdGLS/AMBIGlMpEsQp68BOMBZwRnxy8Jt3/cNkc8FRZRoznuawSnN/MEjZbjiTJ tz5OBdfUiG7HJiRbBRDJ5ZZU+IE9tzg6RQVoiVcg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392035AbfIFC7S (ORCPT ); Thu, 5 Sep 2019 22:59:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:46848 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731491AbfIFC7R (ORCPT ); Thu, 5 Sep 2019 22:59:17 -0400 Received: from sol.localdomain (c-24-5-143-220.hsd1.ca.comcast.net [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 27B7520820; Fri, 6 Sep 2019 02:59:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567738757; bh=ACexdR+rY/Z3d3r2silQsTBU/Sic3Tj3n/fLXapx7Og=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z5Lfc1H0xPm1/pgKky9CKDIBJW0v9gDHE1iYvlrTxK8JJQmK2BB6raa5gjWLc4w97 HWM4WdoW+RzOlQJf9fBPisk0kurc4bTPVvMZ1oYPZ92NqKT1WLQVqiDlzx25ItwhKu B5zFbcYRCk5LMWAVdYyHklBiavkci/wLMjBNZKAU= Date: Thu, 5 Sep 2019 19:59:15 -0700 From: Eric Biggers To: David Howells , Alexander Viro , Miklos Szeredi Cc: syzkaller-bugs@googlegroups.com, syzbot+7d6a57304857423318a5@syzkaller.appspotmail.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] vfs: set fs_context::user_ns for reconfigure Message-ID: <20190906025915.GB803@sol.localdomain> Mail-Followup-To: David Howells , Alexander Viro , Miklos Szeredi , syzkaller-bugs@googlegroups.com, syzbot+7d6a57304857423318a5@syzkaller.appspotmail.com, linux-fsdevel@vger.kernel.org References: <0000000000007bc3a0058e460627@google.com> <20190822051633.12980-1-ebiggers@kernel.org> <20190831031228.GE22191@zzz.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190831031228.GE22191@zzz.localdomain> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Aug 30, 2019 at 10:12:28PM -0500, Eric Biggers wrote: > On Wed, Aug 21, 2019 at 10:16:33PM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > fs_context::user_ns is used by fuse_parse_param(), even during remount, > > so it needs to be set to the existing value for reconfigure. > > > > Reproducer: > > > > #include > > #include > > > > int main() > > { > > char opts[128]; > > int fd = open("/dev/fuse", O_RDWR); > > > > sprintf(opts, "fd=%d,rootmode=040000,user_id=0,group_id=0", fd); > > mkdir("mnt", 0777); > > mount("foo", "mnt", "fuse.foo", 0, opts); > > mount("foo", "mnt", "fuse.foo", MS_REMOUNT, opts); > > } > > > > Crash: > > BUG: kernel NULL pointer dereference, address: 0000000000000000 > > #PF: supervisor read access in kernel mode > > #PF: error_code(0x0000) - not-present page > > PGD 0 P4D 0 > > Oops: 0000 [#1] SMP > > CPU: 0 PID: 129 Comm: syz_make_kuid Not tainted 5.3.0-rc5-next-20190821 #3 > > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-20181126_142135-anatol 04/01/2014 > > RIP: 0010:map_id_range_down+0xb/0xc0 kernel/user_namespace.c:291 > > [...] > > Call Trace: > > map_id_down kernel/user_namespace.c:312 [inline] > > make_kuid+0xe/0x10 kernel/user_namespace.c:389 > > fuse_parse_param+0x116/0x210 fs/fuse/inode.c:523 > > vfs_parse_fs_param+0xdb/0x1b0 fs/fs_context.c:145 > > vfs_parse_fs_string+0x6a/0xa0 fs/fs_context.c:188 > > generic_parse_monolithic+0x85/0xc0 fs/fs_context.c:228 > > parse_monolithic_mount_data+0x1b/0x20 fs/fs_context.c:708 > > do_remount fs/namespace.c:2525 [inline] > > do_mount+0x39a/0xa60 fs/namespace.c:3107 > > ksys_mount+0x7d/0xd0 fs/namespace.c:3325 > > __do_sys_mount fs/namespace.c:3339 [inline] > > __se_sys_mount fs/namespace.c:3336 [inline] > > __x64_sys_mount+0x20/0x30 fs/namespace.c:3336 > > do_syscall_64+0x4a/0x1a0 arch/x86/entry/common.c:290 > > entry_SYSCALL_64_after_hwframe+0x49/0xbe > > > > Reported-by: syzbot+7d6a57304857423318a5@syzkaller.appspotmail.com > > Fixes: 408cbe695350 ("vfs: Convert fuse to use the new mount API") > > Cc: David Howells > > Cc: Miklos Szeredi > > Signed-off-by: Eric Biggers > > --- > > fs/fs_context.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/fs/fs_context.c b/fs/fs_context.c > > index cc61d305dc4b..44c4174b250a 100644 > > --- a/fs/fs_context.c > > +++ b/fs/fs_context.c > > @@ -279,10 +279,8 @@ static struct fs_context *alloc_fs_context(struct file_system_type *fs_type, > > fc->user_ns = get_user_ns(reference->d_sb->s_user_ns); > > break; > > case FS_CONTEXT_FOR_RECONFIGURE: > > - /* We don't pin any namespaces as the superblock's > > - * subscriptions cannot be changed at this point. > > - */ > > atomic_inc(&reference->d_sb->s_active); > > + fc->user_ns = get_user_ns(reference->d_sb->s_user_ns); > > fc->root = dget(reference); > > break; > > } > > -- > > 2.22.1 > > Ping. > Ping. This is still broken in linux-next. - Eric