From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B12EC49ED7 for ; Mon, 16 Sep 2019 17:16:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7975C2186A for ; Mon, 16 Sep 2019 17:16:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729544AbfIPRQR (ORCPT ); Mon, 16 Sep 2019 13:16:17 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:59650 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729526AbfIPRQR (ORCPT ); Mon, 16 Sep 2019 13:16:17 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9ube-0001uZ-DH; Mon, 16 Sep 2019 17:16:06 +0000 Date: Mon, 16 Sep 2019 18:16:06 +0100 From: Al Viro To: Linus Torvalds Cc: kernel test robot , "zhengbin (A)" , Jan Kara , Andrew Morton , linux-fsdevel , "zhangyi (F)" , renxudong1@huawei.com, Hou Tao , LKP Subject: Re: 266a9a8b41: WARNING:possible_recursive_locking_detected Message-ID: <20190916171606.GA1131@ZenIV.linux.org.uk> References: <20190914161622.GS1131@ZenIV.linux.org.uk> <20190916020434.tutzwipgs4f6o3di@inn2.lkp.intel.com> <20190916025827.GY1131@ZenIV.linux.org.uk> <20190916030355.GZ1131@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sun, Sep 15, 2019 at 08:44:05PM -0700, Linus Torvalds wrote: > On Sun, Sep 15, 2019 at 8:04 PM Al Viro wrote: > > > > Perhaps lockref_get_nested(struct lockref *lockref, unsigned int subclass)? > > With s/spin_lock/spin_lock_nested/ in the body... > > Sure. Under the usual CONFIG_DEBUG_LOCK_ALLOC, with the non-debug case > just turning into a regular lockref_get(). > > Sounds fine to me. Done and force-pushed into vfs.git#fixes