From: Matthew Wilcox <willy@infradead.org>
To: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: direct-io: Fixed a Documentation build warn
Date: Tue, 24 Sep 2019 05:23:10 -0700 [thread overview]
Message-ID: <20190924122310.GF1855@bombadil.infradead.org> (raw)
In-Reply-To: <20190924121920.GA4593@madhuparna-HP-Notebook>
On Tue, Sep 24, 2019 at 05:49:25PM +0530, Madhuparna Bhowmik wrote:
> Adds the description about
> offset within the code.
Why?
> @@ -255,6 +254,7 @@ void dio_warn_stale_pagecache(struct file *filp)
> */
> static ssize_t dio_complete(struct dio *dio, ssize_t ret, unsigned int flags)
> {
> + /* offset: the byte offset in the file of the completed operation */
> loff_t offset = dio->iocb->ki_pos;
> ssize_t transferred = 0;
> int err;
This is not normal practice within the Linux kernel. I suggest reading
section 8 of Documentation/process/coding-style.rst
next prev parent reply other threads:[~2019-09-24 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 12:19 [PATCH] fs: direct-io: Fixed a Documentation build warn Madhuparna Bhowmik
2019-09-24 12:23 ` Matthew Wilcox [this message]
2019-09-24 13:16 ` [Linux-kernel-mentees] " Shuah Khan
-- strict thread matches above, loose matches on Subject: below --
2019-09-25 20:06 Madhuparna Bhowmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924122310.GF1855@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madhuparnabhowmik04@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).