From: Petr Vorel <pvorel@suse.cz>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Amir Goldstein <amir73il@gmail.com>,
Dave Chinner <dchinner@redhat.com>,
Cyril Hrubis <chrubis@suse.cz>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
ltp@lists.linux.it
Subject: Re: copy_file_range() errno changes introduced in v5.3-rc1
Date: Thu, 26 Sep 2019 18:19:06 +0200 [thread overview]
Message-ID: <20190926161906.GD23296@dell5510> (raw)
In-Reply-To: <20190926160432.GC9916@magnolia>
Hi Darrick,
> On Thu, Sep 26, 2019 at 05:56:08PM +0200, Petr Vorel wrote:
> > Hi Amir,
> > I'm going to fix LTP test copy_file_range02 before upcoming LTP release.
> > There are some returning errno changes introduced in v5.3-rc1, part of commit 40f06c799539
> > ("Merge tag 'copy-file-range-fixes-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux").
> > These changes looks pretty obvious as wanted, but can you please confirm it they were intentional?
> > * 5dae222a5ff0 ("vfs: allow copy_file_range to copy across devices") started to return -EXDEV.
> > * 96e6e8f4a68d ("vfs: add missing checks to copy_file_range") started to return -EPERM, -ETXTBSY, -EOVERFLOW.
> I'm not Amir, but by my recollection, yes, those are intentional. :)
Thanks for a quick confirmation.
> --D
Kind regards,
Petr
next prev parent reply other threads:[~2019-09-26 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 15:56 copy_file_range() errno changes introduced in v5.3-rc1 Petr Vorel
2019-09-26 16:04 ` Darrick J. Wong
2019-09-26 16:19 ` Petr Vorel [this message]
2019-09-26 16:33 ` Amir Goldstein
2019-09-26 16:50 ` Amir Goldstein
2019-09-26 17:57 ` Petr Vorel
2019-09-26 18:07 ` Amir Goldstein
2019-09-27 8:25 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926161906.GD23296@dell5510 \
--to=pvorel@suse.cz \
--cc=amir73il@gmail.com \
--cc=chrubis@suse.cz \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).