From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 386AEC352AA for ; Thu, 26 Sep 2019 16:19:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18EAF222CB for ; Thu, 26 Sep 2019 16:19:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727384AbfIZQTK (ORCPT ); Thu, 26 Sep 2019 12:19:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:44740 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727239AbfIZQTK (ORCPT ); Thu, 26 Sep 2019 12:19:10 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 63CB4B173; Thu, 26 Sep 2019 16:19:08 +0000 (UTC) Date: Thu, 26 Sep 2019 18:19:06 +0200 From: Petr Vorel To: "Darrick J. Wong" Cc: Amir Goldstein , Dave Chinner , Cyril Hrubis , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, ltp@lists.linux.it Subject: Re: copy_file_range() errno changes introduced in v5.3-rc1 Message-ID: <20190926161906.GD23296@dell5510> Reply-To: Petr Vorel References: <20190926155608.GC23296@dell5510> <20190926160432.GC9916@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190926160432.GC9916@magnolia> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi Darrick, > On Thu, Sep 26, 2019 at 05:56:08PM +0200, Petr Vorel wrote: > > Hi Amir, > > I'm going to fix LTP test copy_file_range02 before upcoming LTP release. > > There are some returning errno changes introduced in v5.3-rc1, part of commit 40f06c799539 > > ("Merge tag 'copy-file-range-fixes-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux"). > > These changes looks pretty obvious as wanted, but can you please confirm it they were intentional? > > * 5dae222a5ff0 ("vfs: allow copy_file_range to copy across devices") started to return -EXDEV. > > * 96e6e8f4a68d ("vfs: add missing checks to copy_file_range") started to return -EPERM, -ETXTBSY, -EOVERFLOW. > I'm not Amir, but by my recollection, yes, those are intentional. :) Thanks for a quick confirmation. > --D Kind regards, Petr