From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0883CC47404 for ; Fri, 4 Oct 2019 19:34:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBE2421D81 for ; Fri, 4 Oct 2019 19:34:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Jv4aGSdj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729551AbfJDTeT (ORCPT ); Fri, 4 Oct 2019 15:34:19 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:36048 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725932AbfJDTeT (ORCPT ); Fri, 4 Oct 2019 15:34:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=39rzJJ0pdXke/IjdtbOOLtjMx1KRjEjgc91/jPrJdjE=; b=Jv4aGSdj/INomnpjZjbcPzSF2 jQFL6+DwaKYE3GYNY4BJ/wFAdZqFc55EkTtjTpJQPc+CVVKEU2evXOqAl8tQQPHh8T8ktui+93Y4s ztyOAT1p1Hz00vjM7dV2i+ZK1ePjleXmBeVpg7ZG3pv2I9YNvqbz61mmZMJ06aPXkjxnq1+1Pd1t6 aWpH0QFRZBjubmfzXMUryWLXWidFtfy3WMVtiBseWMuzNJeaDJdt+1nKLScDJM98xq7D1hDB+KNKj hYbV+XFIykk/efdsO33Z+621sCIPh0wXhYWecp7p1b27vWslz6ktQwFpqOoxIQRtDK8Aj2wl5kMRg 0/ftWBi3g==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGTLG-0006AG-8z; Fri, 04 Oct 2019 19:34:18 +0000 Date: Fri, 4 Oct 2019 12:34:18 -0700 From: Matthew Wilcox To: Hillf Danton Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/15] iomap: Support large pages Message-ID: <20191004193418.GM32665@bombadil.infradead.org> References: <20190925005214.27240-1-willy@infradead.org> <20191002133211.15696-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191002133211.15696-1-hdanton@sina.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Oct 02, 2019 at 09:32:11PM +0800, Hillf Danton wrote: > > On Tue, 24 Sep 2019 17:52:02 -0700 From: Matthew Wilcox (Oracle) > > > > @@ -1415,6 +1415,8 @@ static inline void clear_page_pfmemalloc(struct page *page) > > extern void pagefault_out_of_memory(void); > > > > #define offset_in_page(p) ((unsigned long)(p) & ~PAGE_MASK) > > With the above define, the page_offset function is not named as badly > as 03/15 claims. Just because there exists a function that does the job, does not mean that the other function is correctly named. > > +#define offset_in_this_page(page, p) \ > > + ((unsigned long)(p) & (page_size(page) - 1)) > > What if Ted will post a rfc with offset_in_that_page defined next week? Are you trying to be funny?