From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E231AC47404 for ; Wed, 9 Oct 2019 10:43:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCE102133F for ; Wed, 9 Oct 2019 10:43:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mbobrowski-org.20150623.gappssmtp.com header.i=@mbobrowski-org.20150623.gappssmtp.com header.b="dX7XsLKd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730618AbfJIKno (ORCPT ); Wed, 9 Oct 2019 06:43:44 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:36479 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730588AbfJIKno (ORCPT ); Wed, 9 Oct 2019 06:43:44 -0400 Received: by mail-pf1-f193.google.com with SMTP id y22so1376392pfr.3 for ; Wed, 09 Oct 2019 03:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mbobrowski-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=buLwW9Upwu/0aO+lI2LypZ3xpXUVlEG3VMhVw7VQ4tA=; b=dX7XsLKdVagUMLtcBrpcMoJKqB1Yw5QVHwcVawHbdbXDMHsuuKMAxwM6Lp8nUmWbMw Hh8nMmETmlvvxS49stA2BItM0nGPcjph1SmvmSJeI5JObNPuIXsvgQvA3b2hNIFkTwMy AKnVU0Saig9XXlcLr70wB6FYSB3gMNxobuzpZIZ3AnG1MPKmXUKCiMoGnmgUKTOy52/X QRRKjtwSqf4cg2Fd6d+JP3sk4lawuAzSfuHBZiUbZOrVgo3EKbFa6MmvVJ0s90ghNCxv IPRXtLsMvkh6VVqxtP52foHD3cP25VPyZG6BveL1aJGcAFqWc/Fpx63nLyslH5yT4q0+ 87BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=buLwW9Upwu/0aO+lI2LypZ3xpXUVlEG3VMhVw7VQ4tA=; b=RrrvrCaUx1Wk/HJg86nNU95JSwpzl/3s2yTC901nNKTDU2Ttk3Pd1KZQJk1jve2gg1 e/isk2vG1MRQQsI8MWvqOePZYSOWwzVorgI6opdf7ZEgrYBlMmRJ+KXqNPa7A0tfc10e liDaPOqgiOWRQNlH3Rg0IeHNMqnXP6RwOMyTGDqpAWulBGOLypo1KtTR3RKq7MDYoQfx VwNqbjdUzXdetaEQLQLTO7QnqSykImHg/bE0XFxzDwe5DHMpPr+KB2078IHGhlmpzuh6 79YIrmgh3jhbp9F90Pfdxh2sLdKoFacHl4MPBD9yf7wNLo4Fskiy8nqXh/k0WJK2FiTE yg4A== X-Gm-Message-State: APjAAAWZpxQiys0wiyidPDy+ZulupZBSv6RZ4Nevw5tuMzNZADgA/My/ PRwjLiG8cbh8dIUmu5I21faPuwaycqnS X-Google-Smtp-Source: APXvYqyZMaSmPfryuxffFu9XVIDaj3367+BDwEu69W+82YdMuLOhWY63sSdE+IJew0VhRgP7AvRyOg== X-Received: by 2002:a17:90a:5d0f:: with SMTP id s15mr3238284pji.126.1570617823216; Wed, 09 Oct 2019 03:43:43 -0700 (PDT) Received: from poseidon.bobrowski.net ([114.78.226.167]) by smtp.gmail.com with ESMTPSA id b73sm2213665pga.36.2019.10.09.03.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 03:43:42 -0700 (PDT) Date: Wed, 9 Oct 2019 21:43:36 +1100 From: Matthew Bobrowski To: Ritesh Harjani Cc: tytso@mit.edu, jack@suse.cz, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, david@fromorbit.com, darrick.wong@oracle.com Subject: Re: [PATCH v4 7/8] ext4: reorder map.m_flags checks in ext4_set_iomap() Message-ID: <20191009104334.GE14749@poseidon.bobrowski.net> References: <3551610e53aa1984210a4de04ad6e1a89f5bf0a3.1570100361.git.mbobrowski@mbobrowski.org> <20191009063548.90C434203F@d06av24.portsmouth.uk.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191009063548.90C434203F@d06av24.portsmouth.uk.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Oct 09, 2019 at 12:05:47PM +0530, Ritesh Harjani wrote: > You may be changing the function parameters & name here, > (in ext4_set_iomap) Hm, maybe. :P It all depends on the outcome of what we discuss in 1/8. > But functionality wise the patch looks good to me. > > You may add: > Reviewed-by: Ritesh Harjani Great, thanks Ritesh! ----