[PATCH] fs: include internal.h for missing declarations

[PATCH] fs: include internal.h for missing declarations

[Ben Dooks]

The declarations of __block_write_begin_int and guard_bio_eod
are needed from internal.h so include it to fix the following
sparse warnings:

fs/buffer.c:1930:5: warning: symbol '__block_write_begin_int' was not declared. Should it be static?
fs/buffer.c:2994:6: warning: symbol 'guard_bio_eod' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 fs/buffer.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/buffer.c b/fs/buffer.c
index 86a38b979323..792f22a88e67 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -48,6 +48,8 @@
 #include <linux/sched/mm.h>
 #include <trace/events/block.h>
 
+#include "internal.h"
+
 static int fsync_buffers_list(spinlock_t *lock, struct list_head *list);
 static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,
 			 enum rw_hint hint, struct writeback_control *wbc);
-- 
2.23.0

Re: [PATCH] fs: include internal.h for missing declarations

[Jan Kara]

On Fri 11-10-19 18:00:39, Ben Dooks wrote:
> The declarations of __block_write_begin_int and guard_bio_eod
> are needed from internal.h so include it to fix the following
> sparse warnings:
> 
> fs/buffer.c:1930:5: warning: symbol '__block_write_begin_int' was not declared. Should it be static?
> fs/buffer.c:2994:6: warning: symbol 'guard_bio_eod' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

OK, makes sense to keep declarations in sync with real functions. Thanks
for the patch a feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: linux-fsdevel@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  fs/buffer.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 86a38b979323..792f22a88e67 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -48,6 +48,8 @@
>  #include <linux/sched/mm.h>
>  #include <trace/events/block.h>
>  
> +#include "internal.h"
> +
>  static int fsync_buffers_list(spinlock_t *lock, struct list_head *list);
>  static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,
>  			 enum rw_hint hint, struct writeback_control *wbc);
> -- 
> 2.23.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR