From: Christoph Hellwig <hch@infradead.org>
To: yangerkun <yangerkun@huawei.com>
Cc: hch@infradead.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, yi.zhang@huawei.com,
houtao1@huawei.com
Subject: Re: [PATCH] iomap: fix the logic about poll io in iomap_dio_bio_actor
Date: Tue, 15 Oct 2019 01:05:41 -0700 [thread overview]
Message-ID: <20191015080541.GE3055@infradead.org> (raw)
In-Reply-To: <20191014144313.26313-1-yangerkun@huawei.com>
On Mon, Oct 14, 2019 at 10:43:13PM +0800, yangerkun wrote:
> Just set REQ_HIPRI for the last bio in iomap_dio_bio_actor. Because
> multi bio created by this function can goto different cpu since this
> process can be preempted by other process. And in iomap_dio_rw we will
> just poll for the last bio. Fix it by only set polled for the last bio.
I agree that there is a problem with the separate poll queue now. But
doing partially polled I/O also doesn't seem very useful. Until we
can find a way to poll for multiple bios from one kiocb I think we need
to limit polling to iocbs with just a single bio. Can you look into
that? __blkdev_direct_IO do_blockdev_direct_IO probably have the same
issues. The former should be just as simple to fix, and for the latter
it might make sense to drop polling support entirely.
next prev parent reply other threads:[~2019-10-15 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 14:43 [PATCH] iomap: fix the logic about poll io in iomap_dio_bio_actor yangerkun
2019-10-15 8:05 ` Christoph Hellwig [this message]
2019-10-15 13:50 ` yangerkun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015080541.GE3055@infradead.org \
--to=hch@infradead.org \
--cc=houtao1@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).