From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77906ECE588 for ; Tue, 15 Oct 2019 12:42:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FCF421A49 for ; Tue, 15 Oct 2019 12:42:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="bhvh6DZx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727699AbfJOMmE (ORCPT ); Tue, 15 Oct 2019 08:42:04 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:43344 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726721AbfJOMmE (ORCPT ); Tue, 15 Oct 2019 08:42:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=K8My3sl/gg2JmTvVxZoaNJwh8oIqZH5oOgN3ys0cXS4=; b=bhvh6DZxNpf0Nd8suS3/lOV+C ulOYht8EVPIoDG3pluiw186pLIKGnnu9BW1/Io0jaonzd7FvhTGpd6K6NX5UhoWr36b7CIwFykMSs PL9/NnzznAFK+SUOupvtss7BvVHDBPmsGRPhcou7RsykrdhCqTWda+3N9jFQhlcHEsy5DOWgKRqeJ xZ7ufOoKtTDqtH1uoK4/E31dQKerlfNSNoUsfDxD9vlNi5tFSAgTeV/FthmI0nXqacfqC1Lz70SRb 1Z09bx8ehD/HA0HIAXtFPVCCmWRUJ6u43i0gbz/2n0eUBja1aACF6KgiYuhe0U+1RfxQeCeTPXhOS XA3scbLAQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKM9C-0007lQ-SE; Tue, 15 Oct 2019 12:41:54 +0000 Date: Tue, 15 Oct 2019 05:41:54 -0700 From: Christoph Hellwig To: Ben Dooks Cc: linux-kernel@lists.codethink.co.uk, Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/namespace: add __user to open_tree and move_mount syscalls Message-ID: <20191015124154.GA23798@infradead.org> References: <20191015103502.27691-1-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191015103502.27691-1-ben.dooks@codethink.co.uk> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Oct 15, 2019 at 11:35:02AM +0100, Ben Dooks wrote: > -SYSCALL_DEFINE3(open_tree, int, dfd, const char *, filename, unsigned, flags) > +SYSCALL_DEFINE3(open_tree, int, dfd, const char __user *, filename, unsigned, flags) Please make sure to wrap lines after 80 characters. Otherwise this looks good.