From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: fsdevel <linux-fsdevel@vger.kernel.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: iomap: use SECTOR_SIZE instead of 512 in iomap_page definition
Date: Tue, 15 Oct 2019 08:52:24 -0700 [thread overview]
Message-ID: <20191015155224.GA16024@infradead.org> (raw)
In-Reply-To: <123556d7-968c-70a6-1049-38b2f279f5a1@redhat.com>
On Tue, Oct 15, 2019 at 10:39:36AM -0500, Eric Sandeen wrote:
> iomap_page_create() initializes the uptodate bitmap using the SECTOR_SIZE
> macro, so use that in the definition as well, for consistency and safety.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> Last time there was a concern about pulling in blkdev.h just for this,
> but that's already been done now, so try again.
Note that the iomap writepage series, which is hopefully about to be
merged moves this declaration around.
next prev parent reply other threads:[~2019-10-15 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 15:39 iomap: use SECTOR_SIZE instead of 512 in iomap_page definition Eric Sandeen
2019-10-15 15:52 ` Christoph Hellwig [this message]
2019-10-15 16:16 ` Matthew Wilcox
2019-10-15 16:19 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015155224.GA16024@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).