* [PATCH 1/2] hfs: add a check for hfs_bnode_find
@ 2019-10-16 12:05 Chuhong Yuan
0 siblings, 0 replies; only message in thread
From: Chuhong Yuan @ 2019-10-16 12:05 UTC (permalink / raw)
Cc: linux-fsdevel, linux-kernel, Chuhong Yuan
hfs_brec_update_parent misses a check for hfs_bnode_find and may miss
the failure.
Add a check for it like what is done in again.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
fs/hfs/brec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/hfs/brec.c b/fs/hfs/brec.c
index 896396554bcc..e6af05a4cd1b 100644
--- a/fs/hfs/brec.c
+++ b/fs/hfs/brec.c
@@ -430,6 +430,8 @@ static int hfs_brec_update_parent(struct hfs_find_data *fd)
new_node->parent = tree->root;
}
fd->bnode = hfs_bnode_find(tree, new_node->parent);
+ if (IS_ERR(fd->bnode))
+ return PTR_ERR(fd->bnode);
/* create index key and entry */
hfs_bnode_read_key(new_node, fd->search_key, 14);
cnid = cpu_to_be32(new_node->this);
--
2.20.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-10-16 12:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-16 12:05 [PATCH 1/2] hfs: add a check for hfs_bnode_find Chuhong Yuan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).