From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=uifb=YK=vger.kernel.org=linux-fsdevel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id AC926ECE599
	for <linux-fsdevel@archiver.kernel.org>; Thu, 17 Oct 2019 01:59:06 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 8B4C22082C
	for <linux-fsdevel@archiver.kernel.org>; Thu, 17 Oct 2019 01:59:06 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2391769AbfJQB7D (ORCPT
        <rfc822;linux-fsdevel@archiver.kernel.org>);
        Wed, 16 Oct 2019 21:59:03 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:59274 "EHLO
        ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729268AbfJQB7D (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Wed, 16 Oct 2019 21:59:03 -0400
Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux))
        id 1iKv41-0000yX-4v; Thu, 17 Oct 2019 01:58:53 +0000
Date:   Thu, 17 Oct 2019 02:58:53 +0100
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     syzbot <syzbot+76a43f2b4d34cfc53548@syzkaller.appspotmail.com>,
        akpm@osdl.org, deepa.kernel@gmail.com, hch@infradead.org,
        jlayton@kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, lkundrak@v3.sk,
        syzkaller-bugs@googlegroups.com, tklauser@nuerscht.ch,
        trond.myklebust@fys.uio.no
Subject: Re: KASAN: use-after-free Read in mnt_warn_timestamp_expiry
Message-ID: <20191017015853.GR26530@ZenIV.linux.org.uk>
References: <0000000000007f489b0595115374@google.com>
 <20191017014755.GA1552@sol.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191017014755.GA1552@sol.localdomain>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-fsdevel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-fsdevel.vger.kernel.org>
X-Mailing-List: linux-fsdevel@vger.kernel.org

On Wed, Oct 16, 2019 at 06:47:55PM -0700, Eric Biggers wrote:
> On Wed, Oct 16, 2019 at 06:42:11PM -0700, syzbot wrote:
> > ==================================================================
> > BUG: KASAN: use-after-free in mnt_warn_timestamp_expiry+0x4a/0x250
> > fs/namespace.c:2471
> > Read of size 8 at addr ffff888099937328 by task syz-executor.1/18510
> > 
> 
> Looks like a duplicate of this:
> 
> #syz dup: KASAN: use-after-free Read in do_mount
> 
> See the existing thread and proposed fix here:
> https://lkml.kernel.org/linux-fsdevel/000000000000805e5505945a234b@google.com/T/#u

FWIW, I'd go with your "move mnt_warn_timestamp_expiry() up".  However,
I'd probably turn the message into something like
	foofs filesystem getting mounted at /mnt/barf supports...
And s/mounted/reconfigured/ if mnt_has_parent(mnt) is already true.

Objections?

Al, currently experiencing the joy of being ears-deep in 5 different shitpiles
simultaneously...