From: Christoph Hellwig <hch@infradead.org>
To: "Theodore Y. Ts'o" <tytso@mit.edu>
Cc: Dave Chinner <david@fromorbit.com>,
linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Matthew Bobrowski <mbobrowski@mbobrowski.org>
Subject: Re: [PATCH v2] iomap: iomap that extends beyond EOF should be marked dirty
Date: Thu, 17 Oct 2019 07:17:05 -0700 [thread overview]
Message-ID: <20191017141705.GA31558@infradead.org> (raw)
In-Reply-To: <20191017122911.GC25548@mit.edu>
On Thu, Oct 17, 2019 at 08:29:11AM -0400, Theodore Y. Ts'o wrote:
> > + /*
> > + * Writes that span EOF might trigger an IO size update on completion,
> > + * so consider them to be dirty for the purposes of O_DSYNC even if
> > + * there is no other metadata changes being made or are pending here.
> > + */
> > iomap->flags = 0;
> > - if (ext4_inode_datasync_dirty(inode))
> > + if (ext4_inode_datasync_dirty(inode) ||
> > + offset + length > i_size_read(inode))
> > iomap->flags |= IOMAP_F_DIRTY;
> > +
> > iomap->bdev = inode->i_sb->s_bdev;
> > iomap->dax_dev = sbi->s_daxdev;
> > iomap->offset = (u64)first_block << blkbits;
>
> Ext4 is not currently using iomap for any kind of writing right now,
> so perhaps this should land via Matthew's patchset?
It does for DAX, which is one of the consumers of IOMAP_F_DIRTY.
next prev parent reply other threads:[~2019-10-17 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 5:11 [PATCH] iomap: iomap that extends beyond EOF should be marked dirty Dave Chinner
2019-10-16 5:25 ` Dave Chinner
2019-10-16 5:27 ` Darrick J. Wong
2019-10-16 6:40 ` Christoph Hellwig
2019-10-16 6:06 ` [PATCH v2] " Dave Chinner
2019-10-16 6:43 ` Christoph Hellwig
2019-10-17 12:29 ` Theodore Y. Ts'o
2019-10-17 14:17 ` Christoph Hellwig [this message]
2019-10-17 14:48 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017141705.GA31558@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mbobrowski@mbobrowski.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).