From: Al Viro <viro@zeniv.linux.org.uk>
To: David Howells <dhowells@redhat.com>
Cc: Nicolas Pitre <nico@fluxnic.net>,
Maxime Bizon <mbizon@freebox.fr>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] cramfs: fix usage on non-MTD device
Date: Mon, 21 Oct 2019 15:04:24 +0100 [thread overview]
Message-ID: <20191021140424.GU26530@ZenIV.linux.org.uk> (raw)
In-Reply-To: <18923.1571665539@warthog.procyon.org.uk>
On Mon, Oct 21, 2019 at 02:45:39PM +0100, David Howells wrote:
> Nicolas Pitre <nico@fluxnic.net> wrote:
>
> > From: Maxime Bizon <mbizon@freebox.fr>
> >
> > When both CONFIG_CRAMFS_MTD and CONFIG_CRAMFS_BLOCKDEV are enabled, if
> > we fail to mount on MTD, we don't try on block device.
> >
> > Fixes: 74f78fc5ef43 ("vfs: Convert cramfs to use the new mount API")
> >
> > Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
> > Signed-off-by: Nicolas Pitre <nico@fluxnic.net>
>
> Acked-by: David Howells <dhowells@redhat.com>
FWIW, the thing that worries me here is the possibility of
side effects on fs_context in case if fill_super fails really
late... OTOH, cramfs one seems to be safe in that respect.
OK, will apply, but that's fairly brittle and needs to be
documented. If we *ever* grow non-trivial options parsing
there, that'll be a serious landmine. If something gets
transferred from fs_context into a superblock, which
fails later in setup and takes that object with it, the
second part (get_tree_bdev()) would be in trouble.
prev parent reply other threads:[~2019-10-21 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-19 19:24 [PATCH] cramfs: fix usage on non-MTD device Nicolas Pitre
2019-10-21 13:45 ` David Howells
2019-10-21 14:04 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021140424.GU26530@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mbizon@freebox.fr \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).