From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB57BCA9EAF for ; Tue, 22 Oct 2019 01:58:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB994207FC for ; Tue, 22 Oct 2019 01:58:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mbobrowski-org.20150623.gappssmtp.com header.i=@mbobrowski-org.20150623.gappssmtp.com header.b="oMKguG/Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729270AbfJVB6m (ORCPT ); Mon, 21 Oct 2019 21:58:42 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:45387 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727264AbfJVB6m (ORCPT ); Mon, 21 Oct 2019 21:58:42 -0400 Received: by mail-pg1-f196.google.com with SMTP id r1so8928786pgj.12 for ; Mon, 21 Oct 2019 18:58:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mbobrowski-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ot/px8XAvgp2k4Y12zJFTxEco31g9YFn1T6HKU1iFrE=; b=oMKguG/ZYHhfLtn8kf8xUd4Jbz6d0iHm0g3U6wbFf1TokrLZMEz1QRkj7J2CM/eD1Z phOijuSuHGHliPSIvTQ/Nkl0fKXW3PuyzcjjdUv4xirbcJpdjYe5ZYjkmQkNRpW12v0X x5Ifz2OuLnCUQlIlBlIye6aB8Nf1zcQ4F7JzQwNfPIcHsdHwBTkuxvDPMZqcx+dTx2gV ZrBiyl2T/I7cF+cbfd8tdv0vXXr0wrXl+i8W1BmsyvdTF7EkxeZf71pVYw72k/itltiq kYaCAe9bddksq+Fzewm9MbjxB4fpKnvOywxLXcRQWt28dKGM/O7yMu5Q8aeqirC6SmVP gvbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ot/px8XAvgp2k4Y12zJFTxEco31g9YFn1T6HKU1iFrE=; b=B+jrUtEg9mA4KZxwBq8onxNdu3FMm8SCxJGJTtofI7PDN8skiPhVjd70JvVIxS9eKC 4zrsyNpd1tvWnpd8ID0xqjv1LS3y0XnuHMM7AfABhs8Q0yfjVz358eSZm36tw4y0faz9 7tWyW4JU3i6vdhGhDl9+jK4/bGqyCSpNfd17Qk1lJpmJd5P/agTWScj4X2CVEhmGs72q iaKIuQCqlno/V7Is6CnTY39KglinH+x/AqgLIofNRUU83DZFWX9D1zTiGfP7oGF2utjH JNJUqrPLe/RGMYmwCZv7tP+FeQUmTL19zYG25azv2gTMiOprDonrU5hLo0ycWxzL97jy ppGw== X-Gm-Message-State: APjAAAV1VVDm/tIHgK04nul0ERUKaf5gQVLwbhHl+MFEuMuZvP1GxJrp iHNY+PsXNyQwfjKd+8qaDdFT X-Google-Smtp-Source: APXvYqynliDSFtplvBI+UibC5ybCW5IEI0HWbVgSi5OOU69eFze1mVM+3a/YOWXOmYJY8NF6bJWJQg== X-Received: by 2002:aa7:9907:: with SMTP id z7mr1253810pff.133.1571709521277; Mon, 21 Oct 2019 18:58:41 -0700 (PDT) Received: from athena.bobrowski.net (n1-41-199-60.bla2.nsw.optusnet.com.au. [1.41.199.60]) by smtp.gmail.com with ESMTPSA id a13sm20575566pfg.10.2019.10.21.18.58.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2019 18:58:40 -0700 (PDT) Date: Tue, 22 Oct 2019 12:58:34 +1100 From: Matthew Bobrowski To: Jan Kara Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, david@fromorbit.com, darrick.wong@oracle.com Subject: Re: [PATCH v5 07/12] ext4: introduce direct I/O read using iomap infrastructure Message-ID: <20191022015834.GD5092@athena.bobrowski.net> References: <280de880787dc7c064c309efb685f95d4ff732a9.1571647179.git.mbobrowski@mbobrowski.org> <20191021134131.GF25184@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191021134131.GF25184@quack2.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Oct 21, 2019 at 03:41:31PM +0200, Jan Kara wrote: > On Mon 21-10-19 20:18:37, Matthew Bobrowski wrote: > > This patch introduces a new direct I/O read path which makes use of > > the iomap infrastructure. > > > > The new function ext4_do_read_iter() is responsible for calling into > > the iomap infrastructure via iomap_dio_rw(). If the read operation > > performed on the inode is not supported, which is checked via > > ext4_dio_supported(), then we simply fallback and complete the I/O > > using buffered I/O. > > > > Existing direct I/O read code path has been removed, as it is no > > longer required. > > > > Signed-off-by: Matthew Bobrowski > > Looks good to me. You can add: > > Reviewed-by: Jan Kara > > BTW, I think I gave you my Reviewed-by tag for this patch also last time > and this patch didn't change since then. You can just include the tag in > your posting in that case. The lock pattern was dropped here, so I thought I'd just have you review it again to be sure that you didn't object. But anyway, thank you! ----