From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1041ACA9EB6 for ; Wed, 23 Oct 2019 10:35:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D144F2064A for ; Wed, 23 Oct 2019 10:35:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mbobrowski-org.20150623.gappssmtp.com header.i=@mbobrowski-org.20150623.gappssmtp.com header.b="ed00/wQ5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404434AbfJWKf4 (ORCPT ); Wed, 23 Oct 2019 06:35:56 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:36697 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390807AbfJWKf4 (ORCPT ); Wed, 23 Oct 2019 06:35:56 -0400 Received: by mail-pf1-f193.google.com with SMTP id y22so12679494pfr.3 for ; Wed, 23 Oct 2019 03:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mbobrowski-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IGCTYUdGZ/kAtactsj73D19FolPD9OqOn6a2pp38DL4=; b=ed00/wQ5b0JNduMCcXPzDHZ6hgztDx/0N7hnFnNKMPysVwKyUzx9tm5lQYb8wrp4vB t7zMj9n9I1QahJCKxDyggMRDo506VxsMpIJKPoPN2ao0zpjBm/D0QRt3Oa2V7GC1nlkS +2S/ut2fgYX/wpIXau+KOomw5Qu5ovPS3yF0L+BoaxPGqTOmSwvgMdl7L0B86ziHbIcc vDLIOc1oS/D9d538AXuX2qMkumVCaCzk2jhZUcpbwR3suwZGSK96V43yYVqvjYtr1Y0Y kxsG/Q6wrPkZWZNvpdsapThAcJ+72DrUn+YZaNttozeJVAbRuil97E1VCjv3Iyox20sN YDVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IGCTYUdGZ/kAtactsj73D19FolPD9OqOn6a2pp38DL4=; b=H1v48m4jqduEjVhiDhYJ5BqQcexijoLHTv3/SoqMQWCcmgd9nyHpTkA6EAUCVizbAy VbAUCblBifgL7BDUoXs6m7BklMLTB8cw1VEMlQe8Chg4G2jaHZaKeUWxjG6VAZ9SVXfH tL2cUbIRFIXv3dv/oLKwx1UqFns15aDS8Box604i23saGFsBR4KznY+GZSMv7MBrViCg ohksHvHMEATDXZt3SAjZaxa1f3KJdJMgTJoUbQTV2B88Ta+yQFS/hdCeKn3H8CAy1Gq3 gyRJCTWQYGG3c9IiueBsVlf05v7/St7DXnQW30Ru3b6i1L6Q3S7DdO0uht8uHanreHGe mQ2A== X-Gm-Message-State: APjAAAX7b78LrTb5jowoGcg/3f4Wf1oIwfC2eLa0NxlYjz5+OPuDmYcX P9iz6rz0hUlAtigowi//1eYy X-Google-Smtp-Source: APXvYqxDN4nFg1E1mrSmBOqnqzfKhJ041UGZcDGwc6vrrRZBUb5u5S3KRYaqQyFtOHKfYdyLyYI2GA== X-Received: by 2002:a17:90a:8505:: with SMTP id l5mr10774993pjn.41.1571826954909; Wed, 23 Oct 2019 03:35:54 -0700 (PDT) Received: from bobrowski ([110.232.114.101]) by smtp.gmail.com with ESMTPSA id c66sm3570020pfb.25.2019.10.23.03.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2019 03:35:54 -0700 (PDT) Date: Wed, 23 Oct 2019 21:35:48 +1100 From: Matthew Bobrowski To: Ritesh Harjani Cc: Jan Kara , tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@infradead.org, david@fromorbit.com, darrick.wong@oracle.com Subject: Re: [PATCH v5 04/12] ext4: introduce new callback for IOMAP_REPORT Message-ID: <20191023103548.GD6725@bobrowski> References: <20191021133715.GD25184@quack2.suse.cz> <20191022015535.GC5092@athena.bobrowski.net> <20191023063925.84F6C4C044@d06av22.portsmouth.uk.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191023063925.84F6C4C044@d06av22.portsmouth.uk.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Oct 23, 2019 at 12:09:24PM +0530, Ritesh Harjani wrote: > On 10/22/19 7:25 AM, Matthew Bobrowski wrote: > > On Mon, Oct 21, 2019 at 03:37:15PM +0200, Jan Kara wrote: > > > On Mon 21-10-19 20:18:09, Matthew Bobrowski wrote: > > > One nit below. > > > > + ext4_es_find_extent_range(inode, &ext4_es_is_delayed, > > > > + map->m_lblk, end, &es); > > > > + > > > > + if (!es.es_len || es.es_lblk > end) > > > > + return false; > > > > + > > > > + if (es.es_lblk > map->m_lblk) { > > > > + map->m_len = es.es_lblk - map->m_lblk; > > > > + return false; > > > > + } > > > > + > > > > + if (es.es_lblk <= map->m_lblk) > > > > + offset = map->m_lblk - es.es_lblk; > > > > + map->m_lblk = es.es_lblk + offset; > > And so, this above line will also be redundant. And, you're absolutely right. Nice catch. Who knew basic math could go such a long way? :P Thanks Ritesh! ----